Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target is sometimes not shown fully on panel captcha #6879

Closed
srirambv opened this issue Nov 11, 2019 · 2 comments · Fixed by brave/brave-core#3996
Closed

Target is sometimes not shown fully on panel captcha #6879

srirambv opened this issue Nov 11, 2019 · 2 comments · Fixed by brave/brave-core#3996

Comments

@srirambv
Copy link
Contributor

Description

Target is sometimes not shown fully on panel captcha. Probably similar to #2956 but device DPI settings were 100%.

Steps to Reproduce

  1. Set locale to Japan and device DPI to 100%(default)
  2. Set env to staging to trigger grant
  3. Open panel, sometimes one of the target is not fully shown due to extra padding on message for other locales

Actual result:

image

Expected result:

Should always show the targets fully

Reproduces how often:

Easy but needs a few retries of failed attempts

Brave version (brave://version info)

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1903 (Build 18362.388)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Probably yes
  • Can you reproduce this issue with the beta channel? Probably yes
  • Can you reproduce this issue with the dev channel? Probably yes
  • Can you reproduce this issue with the nightly channel? Probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@NejcZdovc
Copy link
Contributor

see same problem on macOS, so I think it's not scaling issue

@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Nov 14, 2019
ryanml added a commit to brave/brave-core that referenced this issue Nov 15, 2019
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 19, 2019
@btlechowski
Copy link

btlechowski commented Jan 4, 2020

Verification passed on

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

The issue still reproduces. Logged #7597 per our process.

Verification passed on

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified with

Brave 1.3.88 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)

スクリーンショット 2020-01-10 午前10 39 53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants