Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete unblinded tokens #8181

Closed
NejcZdovc opened this issue Feb 11, 2020 · 3 comments · Fixed by brave/brave-core#5017
Closed

Do not delete unblinded tokens #8181

NejcZdovc opened this issue Feb 11, 2020 · 3 comments · Fixed by brave/brave-core#5017

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 11, 2020

Right now we delete unblinded tokens when they are used. To have history we should just marked them as claimed. We need to add new column redeemed_at which should be timestamp and we insert time stamp when token is used. We also need to update query for getting all tokens as we need to return only tokens that don't have redeemed_at column populated.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 1, 2020

@NejcZdovc need a small clarification reg brave/brave-core#5017. Description of the issue says spent_at should it be redeemed_at? Also, I have sent tip of 1BAT to verified pubs in staging env. I could see records of 4 rows, what does each row indicate?
image

@NejcZdovc
Copy link
Contributor Author

@GeetaSarvadnya updated issue. 1 BAT = 4 tokens (1 token = 0.25 BAT)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 1, 2020

Verification passed on

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified passed with

Brave | 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from

  • Confirmed when promotion = UGP grant (staging env)

Before tipping:
UGP before redeem

After tipping:
UGP after redeem

  • Confirmed when promotion = Ad grant (staging env)

Before tipping:
Ad grant before redeem

After tipping:
Ad grant after redeem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment