Adds redeemed_at to unblinded tokens, removes delete #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
changed the title
NejcZdovc
changed the title
NejcZdovc
force-pushed
the
token-claimed
branch
2 times, most recently
from
a409e2b to
d3043c6
Compare
NejcZdovc
commented
May 4, 2020
| @@ -86,77 +82,4 @@ TEST_F(UnblindedTest, NotEnoughFunds) { | |||
| }); | |||
| } | |||
|
|
|||
| TEST_F(UnblindedTest, PromotionExpiredDeleteToken) { | |||
There was a problem hiding this comment.
deleted as we are not deleting tokens anymore
|
PR for updating DB schema and changelog https://github.com/brave/rewards/pull/6 |
zenparsing
reviewed
May 4, 2020
| @@ -34,6 +34,7 @@ index|sqlite_autoindex_sku_order_1|sku_order| | |||
| index|sqlite_autoindex_sku_order_items_1|sku_order_items| | |||
| index|sqlite_autoindex_sku_transaction_1|sku_transaction| | |||
| index|unblinded_tokens_creds_id_index|unblinded_tokens|CREATE INDEX unblinded_tokens_creds_id_index ON unblinded_tokens (creds_id) | |||
| index|unblinded_tokens_redeem_id_index|unblinded_tokens|CREATE INDEX unblinded_tokens_redeem_id_index ON unblinded_tokens (redeem_id) | |||
There was a problem hiding this comment.
Do we ever search on redeem_id?
There was a problem hiding this comment.
we will in the future
| @@ -728,7 +728,7 @@ class LedgerImpl : public ledger::Ledger { | |||
| const std::string& order_id, | |||
| ledger::GetSKUTransactionCallback callback); | |||
|
|
|||
| virtual void GetUnblindedTokensByBatchTypes( | |||
| virtual void GetSpendableUnblindedTokensByBatchTypes( | |||
zenparsing
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#8181
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
redeem*fields are populated)Reviewer Checklist:
After-merge Checklist:
changes has landed on.