Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Tab" on NTP is not translated #9169

Closed
mKoonrad opened this issue Apr 13, 2020 · 1 comment · Fixed by brave/brave-core#5396
Closed

"New Tab" on NTP is not translated #9169

mKoonrad opened this issue Apr 13, 2020 · 1 comment · Fixed by brave/brave-core#5396

Comments

@mKoonrad
Copy link

Description

You have missing string to translate "New Tab". I check few languages like Polish, French, Czech, Italian, German - no translation in any of them.
image

Steps to Reproduce

  1. Open Brave
  2. See description of empty tab at the top or open new tab.

Actual result:

English strings "New Tab"

Expected result:

Translated string

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.5.123 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision	e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS	Windows 10 OS Version 1909 (Build 18363.752)
JavaScript	V8 8.0.426.30
Flash	(Wyłączone)
User Agent	Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36
Command Line	"C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --disable-domain-reliability --disable-features=WebXrGamepadModule,WebXR,NotificationTriggers,AudioServiceOutOfProcess,SmsReceiver,AllowPopupsDuringPageUnload,VideoPlaybackQuality,LookalikeUrlNavigationSuggestionsUI,AutofillServerCommunication --disable-sync --disable-webrtc-apm-in-audio-service --enable-audio-service-sandbox --enable-dom-distiller --enable-features=WebUIDarkMode,SimplifyHttpsIndicator,PasswordImport --extension-content-verification=enforce_strict --extensions-install-verification=enforce --no-pings --sync-url=https://no-thanks.invalid --enable-features=PasswordImport,SimplifyHttpsIndicator,WebUIDarkMode --disable-features=AutofillServerCommunication,LookalikeUrlNavigationSuggestionsUI,VideoPlaybackQuality,AllowPopupsDuringPageUnload,SmsReceiver,AudioServiceOutOfProcess,NotificationTriggers,WebXR,WebXrGamepadModule --flag-switches-begin --enable-features=PasswordImport,SimplifyHttpsIndicator,WebUIDarkMode,DnsOverHttps --flag-switches-end --enable-audio-service-sandbox --disable-webrtc-apm-in-audio-service --disable-sync
Executable Path	C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe
Profile Path	C:\Users\User\AppData\Local\BraveSoftware\Brave-Browser\User Data\Default
Variations	5e3a236d-4113a79e

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? No
@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 18, 2020
@mkarolin mkarolin self-assigned this Apr 27, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Apr 27, 2020
Fixes brave/brave-browser#9169

Added title override like Chromium's NewTabUI class does.
@mkarolin mkarolin added this to the 1.10.x - Nightly milestone Apr 28, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 28, 2020

Verification PASSED on macOS 10.15.4 x64 Catalina without the following build:

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

New Tab translated in Polish

Zrzut ekranu 2020-04-28 o 7 22 25 PM

New Tab translated in Italian

Schermata 2020-04-28 alle 7 23 21 PM

New Tab translated in German

Bildschirmfoto 2020-04-28 um 7 24 16 PM

Verification passed on

Brave 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Ubuntu 18.04 LTS

Polish
image

German
image

Verification passed on

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

New Tab translated in Polish

image

New Tab translated in German
image

New Tab translated in Italian
image

@rebron rebron changed the title Missing string to translate - New Tab "New Tab" on NTP is not translated Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants