Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes New Tab page title l10n (1.8.x). #5401

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fixes New Tab page title l10n (1.8.x). #5401

merged 1 commit into from
Apr 28, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Apr 28, 2020 •
edited by kjozwiak
Loading

Fixes brave/brave-browser#9169
Uplift from #5396

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@mkarolin mkarolin added this to the 1.8.x - Release milestone Apr 28, 2020
@mkarolin mkarolin requested a review from a team April 28, 2020 03:33
@mkarolin mkarolin self-assigned this Apr 28, 2020
kjozwiak
kjozwiak approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. QA verified #5396 on Nightly as per #5396 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit d56544e into 1.8.x Apr 28, 2020
@kjozwiak kjozwiak deleted the maxk-new_tab-l10n-1.8.x branch April 28, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@mkarolin @kjozwiak