BraveContentSettingsAgentImplBrowserTest.FarbleGetImageData fails

[bridiver]

  kExpectedImageDataHashFarblingOff
    Which is: 261120
  hash
    Which is: 261040
Stack trace:
0   brave_browser_tests                 0x000000010ae6c5be BraveContentSettingsAgentImplBrowserTest_FarbleGetImageData_Test::RunTestOnMainThread() + 2174
1   brave_browser_tests                 0x000000010c645188 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 968
2   brave_browser_tests                 0x000000010db5e42c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 5324
3   brave_browser_tests                 0x000000010db5ce99 ChromeBrowserMainParts::PreMainMessageLoopRun() + 57
4   libcontent.dylib                    0x00000001196569aa content::BrowserMainLoop::PreMainMessageLoopRun() + 74
5   libcontent.dylib                    0x0000000119d64b25 content::StartupTaskRunner::RunAllTasksNow() + 133
6   libcontent.dylib                    0x00000001196558e3 content::BrowserMainLoop::CreateStartupTasks() + 803
7   libcontent.dylib                    0x0000000119658e07 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 103
8   libcontent.dylib                    0x0000000119653b0d content::BrowserMain(content::MainFunctionParams const&) + 253
9   libcontent.dylib                    0x000000011a314ea6 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 998
10  libcontent.dylib                    0x000000011a314a93 content::ContentMainRunnerImpl::Run(bool) + 483
11  libembedder.dylib                   0x00000001206326e9 service_manager::Main(service_manager::MainParams const&) + 3017
12  libcontent.dylib                    0x000000011a313e88 content::ContentMain(content::ContentMainParams const&) + 120
13  brave_browser_tests                 0x000000010c644bfb content::BrowserTestBase::SetUp() + 4571
14  brave_browser_tests                 0x000000010c641816 InProcessBrowserTest::SetUp() + 678

[16149:775:0423/143459.523498:FATAL:feature_list.cc(39)] Check failed: feature_overrides_allowed. FeatureList overrides must happen in the test constructor, before BrowserTestBase::SetUp() has run.
0   libbase.dylib                       0x0000000113be4409 base::debug::CollectStackTrace(void**, unsigned long) + 9
1   libbase.dylib                       0x0000000113a9e6b3 base::debug::StackTrace::StackTrace() + 19
2   libbase.dylib                       0x0000000113ac2439 logging::LogMessage::~LogMessage() + 249
3   libbase.dylib                       0x0000000113aa13bf base::FeatureList::RegisterOverride(base::BasicStringPiece<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > >, base::FeatureList::OverrideState, base::FieldTrial*) + 223
4   libbase.dylib                       0x0000000113aa0d47 base::FeatureList::RegisterOverridesFromCommandLine(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > const&, base::FeatureList::OverrideState) + 135
5   libbase.dylib                       0x0000000113aa0c94 base::FeatureList::InitializeFromCommandLine(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char> > const&) + 116
6   brave_browser_tests                 0x000000010da8505f base::test::ScopedFeatureList::InitWithFeaturesImpl(std::__Cr::vector<base::Feature, std::__Cr::allocator<base::Feature> > const&, std::__Cr::vector<base::test::ScopedFeatureList::FeatureAndParams, std::__Cr::allocator<base::test::ScopedFeatureList::FeatureAndParams> > const&, std::__Cr::vector<base::Feature, std::__Cr::allocator<base::Feature> > const&) + 4335
7   brave_browser_tests                 0x000000010da8543d base::test::ScopedFeatureList::InitAndEnableFeature(base::Feature const&) + 109
8   brave_browser_tests                 0x000000010ae6cf94 BraveContentSettingsAgentImplBrowserTest_FarbleGetImageData_Test::RunTestOnMainThread() + 4692
9   brave_browser_tests                 0x000000010c645188 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 968
10  brave_browser_tests                 0x000000010db5e42c ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 5324
11  brave_browser_tests                 0x000000010db5ce99 ChromeBrowserMainParts::PreMainMessageLoopRun() + 57
12  libcontent.dylib                    0x00000001196569aa content::BrowserMainLoop::PreMainMessageLoopRun() + 74
13  libcontent.dylib                    0x0000000119d64b25 content::StartupTaskRunner::RunAllTasksNow() + 133
14  libcontent.dylib                    0x00000001196558e3 content::BrowserMainLoop::CreateStartupTasks() + 803
15  libcontent.dylib                    0x0000000119658e07 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 103
16  libcontent.dylib                    0x0000000119653b0d content::BrowserMain(content::MainFunctionParams const&) + 253
17  libcontent.dylib                    0x000000011a314ea6 content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) + 998
18  libcontent.dylib                    0x000000011a314a93 content::ContentMainRunnerImpl::Run(bool) + 483
19  libembedder.dylib                   0x00000001206326e9 service_manager::Main(service_manager::MainParams const&) + 3017
20  libcontent.dylib                    0x000000011a313e88 content::ContentMain(content::ContentMainParams const&) + 120
21  brave_browser_tests                 0x000000010c644bfb content::BrowserTestBase::SetUp() + 4571
22  brave_browser_tests                 0x000000010c641816 InProcessBrowserTest::SetUp() + 678
23  brave_browser_tests                 0x000000010bec04ec testing::Test::Run() + 108
24  brave_browser_tests                 0x000000010bec170f testing::TestInfo::Run() + 511
25  brave_browser_tests                 0x000000010bec1f37 testing::TestSuite::Run() + 311
26  brave_browser_tests                 0x000000010bed1e07 testing::internal::UnitTestImpl::RunAllTests() + 1319
27  brave_browser_tests                 0x000000010bed18be testing::UnitTest::Run() + 206
28  brave_browser_tests                 0x000000010da88c5b base::TestSuite::Run() + 187
29  brave_browser_tests                 0x000000010e2eabbc ChromeTestSuiteRunner::RunTestSuite(int, char**) + 92
30  brave_browser_tests                 0x000000010c652456 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 1174
31  brave_browser_tests                 0x000000010e2eb026 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 646
32  brave_browser_tests                 0x000000010c65e837 main + 119
33  libdyld.dylib                       0x00007fff696597fd start + 1

[bsclifton]

@bridiver is this still an issue? I think the tests were added back in - can't remember

[bridiver]

cc @pilgrim-brave

[pilgrim-brave]

Tests were rewritten and simplified in brave/brave-core#5603 and now pass on all platforms.