Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FarbleGetImageData tests #5603

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented May 20, 2020

Resolves brave/brave-browser#8937

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave self-assigned this May 20, 2020
@pilgrim-brave pilgrim-brave requested a review from bbondy May 20, 2020 18:18
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if CI passes

@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_fix_canvas_farbling_test branch 2 times, most recently from ec57290 to 15cd388 Compare May 20, 2020 23:21
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_fix_canvas_farbling_test branch from 15cd388 to 22a9f0a Compare May 21, 2020 02:36
@pilgrim-brave pilgrim-brave merged commit 121180a into master May 21, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_fix_canvas_farbling_test branch May 21, 2020 11:33
@bsclifton bsclifton added this to the 1.11.x - Nightly milestone May 22, 2020
brave-builds pushed a commit that referenced this pull request May 22, 2020
@brave-builds brave-builds mentioned this pull request May 22, 2020
4 tasks
brave-builds pushed a commit that referenced this pull request May 22, 2020
@brave-builds brave-builds mentioned this pull request May 22, 2020
4 tasks
brave-builds pushed a commit that referenced this pull request May 22, 2020
@brave-builds brave-builds mentioned this pull request May 22, 2020
4 tasks
brave-builds pushed a commit that referenced this pull request May 23, 2020
@brave-builds brave-builds mentioned this pull request May 23, 2020
4 tasks
brave-builds pushed a commit that referenced this pull request May 23, 2020
@brave-builds brave-builds mentioned this pull request May 23, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Farbling test fails under Linux and Windows
3 participants