Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binance widget and autocomplete shouldn't use /en/ for all locales #9691

Closed
bbondy opened this issue May 8, 2020 · 2 comments · Fixed by brave/brave-core#7626 or brave/brave-core#7657

Comments

@bbondy
Copy link
Member

bbondy commented May 8, 2020

The Binance widget and autocomplete for site suggestions currently uses URLs with paths /en/
We should use one of these locales if they match first:

"en", "au", "cn", "tw", "ar", "nl", "ph", "fr", "de", "id",
 "it", "ja", "kr", "pl", "br", "pt", "ru", "es", "th", "tr",
 "ua", "vn", "ro", "cs", "he", "bg", "lv", "bn", "sv"

Test Plan

Autocomplete does not apply for Android

  1. Clean profile, with english set as device language
  2. Navigate to the New Tab page, bring the Binance widget to the foreground, set TLD to .com
  3. Ensure that the Buy Crypto button takes you to https://www.binance.com/en/
  4. Repeat steps 1 - 3, but with a language from the list such as French.
  5. Clean profile, with english set as device language
  6. In brave://settings, turn on suggested sites
  7. In a new Tab, type in a keyword such as bitcoin
  8. Confirm that binance.com/en/ is shown as the suggested site
  9. Repeat steps 5 - 8 with a language from the list such as French.
  10. Repeat all steps using a locale that is unsupported, and ensure it defaults to English
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 8, 2020
@bbondy bbondy self-assigned this May 8, 2020
@bsclifton bsclifton changed the title Binance widget and autocomplete shouldn't use /en/ for all lcoales Binance widget and autocomplete shouldn't use /en/ for all locales May 17, 2020
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. feature/widgets and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Sep 8, 2020
@ryanml ryanml assigned ryanml and unassigned bbondy Jan 15, 2021
ryanml added a commit to brave/brave-core that referenced this issue Jan 15, 2021
ryanml added a commit to brave/brave-core that referenced this issue Jan 18, 2021
@ryanml ryanml added this to the 1.21.x - Nightly milestone Jan 19, 2021
@ryanml ryanml added OS/Android Fixes related to Android browser functionality OS/Desktop and removed OS/Android Fixes related to Android browser functionality labels Jan 20, 2021
ryanml added a commit to brave/brave-core that referenced this issue Jan 20, 2021
@srirambv
Copy link
Contributor

srirambv commented Feb 23, 2021

Verification passed on

Brave 1.21.65 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS Linux
  • Verified with supported EN locales (used IE), Buy Crypto button takes to https://www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
EN.mov
  • Verified setting locale to French(FR), Buy Crypto button takes to https://www.binance.com/fr/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/fr/ in suggestion
FR.mov
  • Verified setting locale to Greek(EL), Buy Crypto button takes to https:/www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
Greek.mov

Verification passed on

Brave 1.21.65 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS Windows 10 OS Version 2009 (Build 19042.804)
  • Verified with supported EN locales (used IE), Buy Crypto button takes to https://www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
EN.mov
  • Verified setting locale to German(DE), Buy Crypto button takes to https://www.binance.com/de/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/de/ in suggestion
German.mov
  • Verified setting locale to Finnish(FI), Buy Crypto button takes to https:/www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
Finnish.mov

Verification passed on

Brave 1.21.65 Chromium: 88.0.4324.182 (Official Build) beta (x86_64)
Revision 73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS macOS Version 10.15.7 (Build 19H114)
  • Verified with supported EN locales (used IE), Buy Crypto button takes to https://www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
EN_mac.mov
  • Verified setting locale to Spanish(ES), Buy Crypto button takes to https://www.binance.com/es/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/es/ in suggestion
Spanish.mov
  • Verified setting locale to Kannada(KN), Buy Crypto button takes to https:/www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
Kannada.mov

@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2021

Verification passed on Samsung Tab A with Android 10 running 1.21.70 x64 build

  • Verified with supported EN locales (used IE), Buy Crypto button takes to https://www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
Tablet-EN.mp4
  • Verified setting locale to Netherlands(NL), Buy Crypto button takes to https://www.binance.com/nl/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/nl/ in suggestion
Tablet-NL.mp4
  • Verified setting locale to Hindi(HI), Buy Crypto button takes to https:/www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en/ in suggestion
Tablet-HI.mp4

Verification passed on OnePlus 6T with Android 10 running 1.21.70 x64 build

  • Verified with supported EN locales (used IE), Buy Crypto button takes to https://www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en in suggestion
ARM-EN.mp4
  • Verified setting locale to Romanian(RO), Buy Crypto button takes to https://www.binance.com/ro/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/ro/ in suggestion
ARM-RO.mp4
  • Verified setting locale to Malay(MS), Buy Crypto button takes to https:/www.binance.com/en/
  • Verified enabling Show Brave suggested sites and typing bitcoin brings up https://www.binance.com/en/ in suggestion
ARM-ML.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment