Localizing binance.com buy URL (Android widget) #7657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
force-pushed
the
fix-9691-android
branch
from
dd6314f
to
2c3ba99
Compare
deeppandya
reviewed
Jan 20, 2021
| @@ -111,8 +111,11 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat | |||
| public void onClick(View view) { | |||
| String buyUrl = ""; | |||
| if (buyRadioGroup.getCheckedRadioButtonId() == R.id.com_radio) { | |||
| buyUrl = String.format(BinanceWidgetManager.BINANCE_COM, selectedFiat, | |||
| selectedCrypto, amountEditText.getText()); | |||
| String localizedUrl = BinanceWidgetManager.BINANCE_COM_ONE | |||
There was a problem hiding this comment.
we should use StringBuilder.append instead of +.
There was a problem hiding this comment.
@ryanml i am updating it.
|
All CI steps pass, ios failure is unrelated to this PR and has a pending fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#9691
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan:
Defined in issue