Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds recovery path for may payout problem (uplift to 1.9.x) #5517

Merged
merged 1 commit into from
May 12, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 11, 2020

Uplift of #5495
Fixes brave/brave-browser#9684

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.9.x - Beta milestone May 11, 2020
@NejcZdovc NejcZdovc requested a review from a team May 11, 2020 21:06
@NejcZdovc NejcZdovc requested a review from gdregalo as a code owner May 11, 2020 21:06
@NejcZdovc NejcZdovc self-assigned this May 11, 2020
@NejcZdovc NejcZdovc removed the request for review from gdregalo May 11, 2020 21:06
@kjozwiak
Copy link
Member

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-recover-payout-1.9/1/execution/node/390/log/.

18:21:58  [  FAILED  ] BraveRewardsBrowserTest.ProcessPendingContributions, where TypeParam =  and GetParam() =  (37680 ms)
18:21:58  [543/543] BraveRewardsBrowserTest.ProcessPendingContributions (37762 ms)
18:21:58  1 test failed:
18:21:58      BraveRewardsBrowserTest.ProcessPendingContributions (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2191)

However, the above is a known intermittent issue that will be addressed via brave/brave-browser#5397 and doesn't block uplift.

test-install failed on macOS as per https://ci.brave.com/job/pr-brave-browser-recover-payout-1.9/1/execution/node/472/log/. This is a known intermittent issue that will be resolved via brave/brave-browser#9480 and doesn't block uplift.

Travis also failed due to TEST_SUITE=test-security because of the yargs-parser npm package which is a known issue and not blocking uplift.

@kjozwiak
Copy link
Member

Restarting Win x64 as it looks like pulling the source control failed as per https://ci.brave.com/job/pr-brave-browser-recover-payout-1.9/1/execution/node/96/log/.

java.io.EOFException
	at java.base/java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2820)
	at java.base/java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3315)
	at java.base/java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:907)
	at java.base/java.io.ObjectInputStream.<init>(ObjectInputStream.java:350)
	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:49)
	at hudson.remoting.Command.readFrom(Command.java:142)
	at hudson.remoting.Command.readFrom(Command.java:128)
	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:35)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
Caused: java.io.IOException: Unexpected termination of the channel
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)
Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to i-0912cb4da876628c5
		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1788)
		at hudson.remoting.Request.call(Request.java:202)
		at hudson.remoting.Channel.call(Channel.java:997)
		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)
		at jdk.internal.reflect.GeneratedMethodAccessor1115.invoke(Unknown Source)
		at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
		at java.base/java.lang.reflect.Method.invoke(Method.java:566)
		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)
		at com.sun.proxy.$Proxy100.execute(Unknown Source)
		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1122)
		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1167)
		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:125)
		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:93)
		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:80)
		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
		at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
		at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
		at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
		at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
		at java.base/java.lang.Thread.run(Thread.java:834)
Caused: hudson.remoting.RequestAbortedException
	at hudson.remoting.Request.abort(Request.java:340)
	at hudson.remoting.Channel.terminate(Channel.java:1081)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:94)

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 12, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on Nightly as per #5495 (comment). Ensured that the issue was moved into the appropriate milestone.

@kjozwiak kjozwiak merged commit 8d027bb into 1.9.x May 12, 2020
@kjozwiak kjozwiak deleted the recover-payout-1.9 branch May 12, 2020 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants