-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move data from ledger_state into preferences #9869
Closed
10 tasks done
Milestone
Comments
32 tasks
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
May 25, 2020
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
May 27, 2020
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
May 29, 2020
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
May 31, 2020
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Jun 2, 2020
Verification passed on
Test plan 1:
Test plan 2:
Test plan 3: - Working as expected
Verified passed with
Additional notes:
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should move data from ledger_state file into preferences. We should move following data:
walletInfo->paymentId
(wallet.payment_id
)walletInfo->keyInfoSeed
(wallet.seed
)walletInfo->addressCARD_ID
(wallet.anonymous_card_id
)bootStamp
(creation_stamp
)reconcileStamp
(ac.next_reconcile_stamp
)fee_amount
(ac.amount
)user_changed_fee
(do not persist, just use if for migratingac.amount
)rewards_enabled
(enabled
)auto_contribute
(ac.enabled
)inline_tips
(tips.inline_tips.*
, we would have each entry per media type)All business logic for setting this values should be done in shared lib. Example that needs to be fixed is
RewardsServiceImpl::OnWalletInitialized
The text was updated successfully, but these errors were encountered: