[Desktop] Follow up of #9869 - `Monthly Payment` AC settings are not retained correctly in upgraded profile 1.11.x #10438

GeetaSarvadnya · 2020-06-24T09:57:28Z

Description

Found while testing #9869
Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x

Steps to Reproduce

Scenarios 1:

Clean profile 1.10.x
Enable rewards
Change AC settings values except for monthly payment (keep the monthly payment as it is)
Upgrade profile to 1.11.x
Looks for AC advanced settings value, Monthly Payment value is displayed as 0.0 BAT and dropdown values are empty
Rest other values are displayed as expected

Scenarios 2:

Clean profile 1.10.x
Enable rewards
Change AC settings monthly payment to 50 BAT or any other value
Upgrade profile to 1.11.x
Looks for AC advanced settings value, Monthly Payment value is empty in UI
Click on dropdown shows only 50.0 BAT and other dropdown values are empty
Rest other values are displayed as expected

Note: Min page time, visit and other settings are working as expected.

Actual result:

Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x
Scenario1:

Scenario 2:

Expected result:

AC Advanced settings should be retained correctly in upgraded profile 1.11.x

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.11.75 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Windows 10 OS Version 1903 (Build 18362.900)

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? Yes
Can you reproduce this issue with the dev channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

The text was updated successfully, but these errors were encountered:

GeetaSarvadnya · 2020-06-24T10:29:46Z

Test plan 2 from brave/brave-core#5647 (Upgraded profile from 1.10.x to 1.11.x)
USD conversion values are displayed as 0.0 BAT after the upgrade, but if I reload the page the correct values are displayed
This issue is arising in a clean profile also, after claiming grants in BR panel displays the USD value as 0.0 BAT. The Reload page fixes the issue.

Various pages where USD conversion value is displayed as 0.0 BAT - Upgraded Profile

Clean profile - 1.11.x

@NejcZdovc USD conversion values are not consistent in 1.10.x and 1.11.x. Is this expected? Also, it's not consistent in clean and upgraded profile.

1.10.x - UGP USD conversion value is displayed as 7.41 USD

when upgrade to 1.11.x - UGP USD conversion value is displayed as 7.47 USD

Clean profile 1.11.x UGP USD conversion value is displayed as 7.49 USD

zenparsing · 2020-07-02T16:43:54Z

This repros in nightly (1.12) as well. The issue appears to be that "API parameters" are downloaded from the server and updated after the rewards page has finished loading data from the rewards service, and is not notified that the parameters (like "batRate", default AC amount, and AC choices) have been updated.

This issue should only appear when the user is migrated from 1.10 and the rewards page is open on restart. Potential fixes include:

Add a method to RewardsServiceObserver to allow the front-end to listen for changes to API parameters.
Modify LedgerImpl::GetRewardsParameters to detect an "empty parameters" condition and wait for the API parameter fetch to complete.

LaurenWags · 2020-07-02T17:55:37Z

@zenparsing I noticed that if I do the following, I basically encounter scenario 1, but my Rewards page was not open on restart. Does this have the same problem or should it be logged under a new issue?

Steps:

Install 1.10.97, Enable Rewards
Disable Rewards, close brave://rewards page
Rename profile to dev, launch w/ 1.11.x
Confirm Rewards are still off on upgrade (NTP widget shows message to re-enable, as does panel from BAT logo)
Enable Rewards (I did this from the BAT logo panel)
Open brave://rewards page (clicked on Rewards Settings on panel)
--> on brave://rewards Monthly Payment is 0.000 BAT and that's also the only option available in settings.

Reload of page does not fix. Close/reopen of tab does not fix. However, close/relaunch of the browser + refresh of the opened page after relaunch does fix this.

Brave	1.11.85 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	macOS Version 10.14.6 (Build 18G3020)

zenparsing · 2020-07-02T22:47:48Z

@LaurenWags Great catch. It looks like there's an additional issue with 1.11 (but not 1.12) where API parameters are not fetched when rewards is enabled. (I believe it's not an issue in 1.12 because the everything is restarted every time rewards is turned on, as opposed to just when the browser is started.)

I need to spend a bit more time looking into whether a single fix will solve both issues.

LaurenWags · 2020-07-03T11:44:20Z

Thanks @zenparsing - happy to open a separate issue if needed just let me know!

angellyna1088 · 2020-07-03T23:08:55Z

yes help me open Vào Th 6, 3 thg 7, 2020 lúc 18:44 Lauren <notifications@github.com> đã viết:

…

Thanks @zenparsing <https://github.com/zenparsing> - happy to open a separate issue if needed just let me know! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10438 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP7MBUNJDDTVNCHKC3XVPIDRZXADBANCNFSM4OGP62DA> .

btlechowski · 2020-07-06T12:42:04Z

Reproduced on Ubuntu

Brave	1.11.89 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	Ubuntu 18.04 LTS

LaurenWags · 2020-07-09T19:49:08Z

Adding QA/Blocked label - during testing of PR on Nightly noticed that originally reported issues were not resolved. Shared information with @zenparsing for investigation.

zenparsing · 2020-07-09T20:54:07Z

Investigation uncovered two additional issues related to #7024:

The Select component in brave-ui has a bug where the currently displayed value is not updated when the list of options is updated. I'll see if I can come up with a workaround to avoid a dependency update.
The rewards extension is attempting to load wallet data before the state has been transitioned to prefs, and as a result is setting walletCorrupted to true. Furthermore, when the "wallet initialized" event occurs, a result of LEDGER_OK is is not correctly handled (it should reset walletCorrupted to false).

kjozwiak · 2020-07-14T17:22:22Z

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.15.5 (Build 19F101)

Scenario #1 from #10438 (comment)

Before Refresh	After Refresh

Verified the closing/re-opening brave://rewards several times didn't reproduce the original issue after a refresh
Verified that restarting Brave several times didn't didn't reproduce the original issue after a refresh
Verified that enabling/disabling a-c several times didn't reproduce the original issue after a refresh

Scenario #2 from #10438 (comment)

Before Refresh	After Refresh

Verified the closing/re-opening brave://rewards several times didn't reproduce the original issue after a refresh
Verified that restarting Brave several times didn't didn't reproduce the original issue after a refresh
Verified that enabling/disabling a-c several times didn't reproduce the original issue after a refresh

Scenario #3 from #10438 (comment)

Verified that after enabling Rewards once Brave has been updated, Monthly Payment under brave://settings doesn't appear as 0.000 BAT
Verified that after enabling Rewards once Brave has been updated, Monthly Payment under a-c settings doesn't appear as 0.000 BAT

Went through the above cases with both the selected default which is 20.000 BAT and selected 50.000 BAT from the dropdown. Both cases passed without issues.

Verification passed on


Brave | 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Scenario #1 from #10438 (comment)

Before refresh:

After refresh:

Verified the closing/re-opening brave://rewards several times didn't reproduce the original issue after a refresh
Verified that restarting Brave several times didn't reproduce the original issue after a refresh
Verified that enabling/disabling a-c several times didn't reproduce the original issue after a refresh

Scenario #2 from #10438 (comment)
Before refresh:

After refresh:

Verified the closing/re-opening brave://rewards several times didn't reproduce the original issue after a refresh
Verified that restarting Brave several times didn't reproduce the original issue after a refresh
Verified that enabling/disabling a-c several times didn't reproduce the original issue after a refresh

Scenario #3 from #10438 (comment)

Verified that after enabling Rewards once Brave has been updated, Monthly Payment under brave://settings doesn't appear as 0.000 BAT
Verified that after enabling Rewards once Brave has been updated, Monthly Payment under a-c settings doesn't appear as 0.000 BAT

Went through the above cases with both the selected default which is 20.000 BAT and selected 50.000 BAT from the dropdown. Both cases passed without issues.

Verification passed on

Brave	1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	Ubuntu 18.04 LTS

Verified test plan from #10438 (comment)

Scenario #1
Before refresh

After refresh

Scenario #2
Before refresh

After refresh

Scenario #3

Verified that after enabling Rewards once Brave has been updated, Monthly Payment under brave://settings doesn't appear as 0.000 BAT
Verified that after enabling Rewards once Brave has been updated, Monthly Payment under a-c settings doesn't appear as 0.000 BAT

Went through the above cases with both the selected default which is 20.000 BAT and selected 50.000 BAT from the dropdown. Both cases passed without issues.

GeetaSarvadnya added feature/rewards QA/Yes QA/Test-Plan-Specified OS/Desktop labels Jun 24, 2020

NejcZdovc added this to the 1.11.x - Beta milestone Jun 24, 2020

GeetaSarvadnya changed the title ~~[Desktop] Follow up of #9869 - AC Advanced settings are not retained correctly in upgraded profile 1.11.x~~ [Desktop] Follow up of #9869 - Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x Jun 24, 2020

This was referenced Jun 24, 2020

Move data from ledger_state into preferences #9869

Closed

Remove unneeded saves in ledger_state #9959

Closed

zenparsing self-assigned this Jun 29, 2020

GeetaSarvadnya mentioned this issue Jun 30, 2020

Migrate Rewards settings from JSON to Preferences #7024

Closed

zenparsing mentioned this issue Jul 5, 2020

Wait for initial rewards API parameter fetch from server brave/brave-core#6002

Merged

32 tasks

zenparsing closed this as completed in brave/brave-core#6002 Jul 8, 2020

brave-builds mentioned this issue Jul 9, 2020

Wait for initial rewards API parameter fetch from server (uplift to 1.12.x) brave/brave-core#6048

Merged

4 tasks

NejcZdovc mentioned this issue Jul 9, 2020

Wait for initial rewards API parameter fetch from server (uplift to 1.11.x) brave/brave-core#6050

Merged

4 tasks

LaurenWags added the QA/Blocked label Jul 9, 2020

zenparsing mentioned this issue Jul 10, 2020

Fix UI issues when migrating from rewards JSON to prefs brave/brave-core#6057

Closed

32 tasks

LaurenWags mentioned this issue Jul 13, 2020

[Desktop] monthly payment isn't always displayed on brave://rewards correctly - follow up to 10438 #10717

Closed

NejcZdovc added release-notes/exclude and removed QA/Blocked labels Jul 14, 2020

NejcZdovc mentioned this issue Jul 14, 2020

[Android] Monthly budget dropdown missing after CR84 upgrade #10727

Closed

kjozwiak added the QA Pass-macOS label Jul 14, 2020

GeetaSarvadnya added QA Pass-Win64 and removed QA Pass-Win64 labels Jul 15, 2020

btlechowski added the QA Pass-Linux label Jul 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Desktop] Follow up of #9869 - `Monthly Payment` AC settings are not retained correctly in upgraded profile 1.11.x #10438

[Desktop] Follow up of #9869 - `Monthly Payment` AC settings are not retained correctly in upgraded profile 1.11.x #10438

GeetaSarvadnya commented Jun 24, 2020 •

edited

Loading

GeetaSarvadnya commented Jun 24, 2020 •

edited

Loading

zenparsing commented Jul 2, 2020 •

edited

Loading

LaurenWags commented Jul 2, 2020 •

edited

Loading

zenparsing commented Jul 2, 2020

LaurenWags commented Jul 3, 2020

angellyna1088 commented Jul 3, 2020 via email

btlechowski commented Jul 6, 2020

LaurenWags commented Jul 9, 2020

zenparsing commented Jul 9, 2020 •

edited

Loading

kjozwiak commented Jul 14, 2020 •

edited by btlechowski

Loading

[Desktop] Follow up of #9869 - Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x #10438

[Desktop] Follow up of #9869 - Monthly Payment AC settings are not retained correctly in upgraded profile 1.11.x #10438

Comments

GeetaSarvadnya commented Jun 24, 2020 • edited Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

GeetaSarvadnya commented Jun 24, 2020 • edited Loading

zenparsing commented Jul 2, 2020 • edited Loading

LaurenWags commented Jul 2, 2020 • edited Loading

zenparsing commented Jul 2, 2020

LaurenWags commented Jul 3, 2020

angellyna1088 commented Jul 3, 2020 via email

btlechowski commented Jul 6, 2020

LaurenWags commented Jul 9, 2020

zenparsing commented Jul 9, 2020 • edited Loading

kjozwiak commented Jul 14, 2020 • edited by btlechowski Loading

[Desktop] Follow up of #9869 - `Monthly Payment` AC settings are not retained correctly in upgraded profile 1.11.x #10438

[Desktop] Follow up of #9869 - `Monthly Payment` AC settings are not retained correctly in upgraded profile 1.11.x #10438

GeetaSarvadnya commented Jun 24, 2020 •

edited

Loading

GeetaSarvadnya commented Jun 24, 2020 •

edited

Loading

zenparsing commented Jul 2, 2020 •

edited

Loading

LaurenWags commented Jul 2, 2020 •

edited

Loading

zenparsing commented Jul 9, 2020 •

edited

Loading

kjozwiak commented Jul 14, 2020 •

edited by btlechowski

Loading