Skip to content

Commit

Permalink
Drop use of federated_learning::kFlocIdSortingLshBasedComputation
Browse files Browse the repository at this point in the history
This definition has been dropped upstream as it's enabled by default
now, but even in that case that doesn't make a difference for Brave
as the FlocIdProviderImpl object is never created as per [1], so we
can simply drop these 2 lines.

[1] #8468

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d

commit 77462226d2aa2980c80e009ab7de098407af653d
Author: Yao Xiao <yaoxia@chromium.org>
Date:   Wed Mar 31 23:11:46 2021 +0000

    [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests.

    Bug: 1190992
  • Loading branch information
mariospr committed Apr 20, 2021
1 parent 35a74c2 commit 5d3e150
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,6 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
features::kWebOTP.name,
federated_learning::kFederatedLearningOfCohorts.name,
federated_learning::kFlocIdComputedEventLogging.name,
federated_learning::kFlocIdSortingLshBasedComputation.name,
kSharingQRCodeGenerator.name,
net::features::kFirstPartySets.name,
network_time::kNetworkTimeServiceQuerying.name,
Expand Down
1 change: 0 additions & 1 deletion app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&features::kWebOTP,
&federated_learning::kFederatedLearningOfCohorts,
&federated_learning::kFlocIdComputedEventLogging,
&federated_learning::kFlocIdSortingLshBasedComputation,
&kEnableProfilePickerOnStartupFeature,
&kSharingQRCodeGenerator,
&net::features::kFirstPartySets,
Expand Down

0 comments on commit 5d3e150

Please sign in to comment.