14942: Disable FLoC features and the provider service. #8468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
force-pushed
the
ie_disable_floc
branch
from
024c0e9 to
3ba2d20
Compare
|
As per the issue
The service is completely disabled
covered with
covered with
not sure what it is yet |
iefremov
force-pushed
the
ie_disable_floc
branch
from
3ba2d20 to
8e968f5
Compare
iefremov
force-pushed
the
ie_disable_floc
branch
from
8e968f5 to
c6a2754
Compare
bridiver
approved these changes
Apr 8, 2021
mariospr
added a commit
that referenced
this pull request
Apr 9, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
|
Adding this into the |
|
Do we have a browsertest for |
|
@bbondy Sure, I'll add |
mkarolin
pushed a commit
that referenced
this pull request
Apr 16, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
mariospr
added a commit
that referenced
this pull request
Apr 20, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
mkarolin
pushed a commit
that referenced
this pull request
Apr 21, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
mkarolin
pushed a commit
that referenced
this pull request
Apr 23, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
mkarolin
pushed a commit
that referenced
this pull request
Apr 27, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
mkarolin
pushed a commit
that referenced
this pull request
Apr 30, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
mkarolin
pushed a commit
that referenced
this pull request
May 5, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
mariospr
added a commit
that referenced
this pull request
May 5, 2021
This definition has been dropped upstream as it's enabled by default now, but even in that case that doesn't make a difference for Brave as the FlocIdProviderImpl object is never created as per [1], so we can simply drop these 2 lines. [1] #8468 Chromium change: https://chromium.googlesource.com/chromium/src.git/+/77462226d2aa2980c80e009ab7de098407af653d commit 77462226d2aa2980c80e009ab7de098407af653d Author: Yao Xiao <yaoxia@chromium.org> Date: Wed Mar 31 23:11:46 2021 +0000 [floc] Use sorting-lsh by default. Remove base::Feature and clean up tests. Bug: 1190992
kylehickinson
added a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14942
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Open
brave://componentsand make sure that there is no Federated Learning of Cohorts component:Open the devtools console, type
document.interestCohort()and confirm that you get an error: