Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pending publisher hover messages to Rewards panel (uplift to 1.31.x) #10224

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Add pending publisher hover messages to Rewards panel (uplift to 1.31.x) #10224

merged 1 commit into from
Sep 29, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 23, 2021 •
edited by kjozwiak
Loading

Uplift of #10181
Resolves brave/brave-browser#17974
Resolves brave/brave-browser#18153
Resolves brave/brave-browser#17941

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 23, 2021 13:12
@brave-builds brave-builds requested review from jumde, emerick and a team and removed request for a team September 23, 2021 13:12
@brave-builds brave-builds self-assigned this Sep 23, 2021
@brave-builds brave-builds added this to the 1.31.x - Beta milestone Sep 23, 2021
@stephendonner stephendonner mentioned this pull request Sep 27, 2021
Closed
kjozwiak
kjozwiak approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.31.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10181 (comment).

@kjozwiak kjozwiak merged commit 118f236 into 1.31.x Sep 29, 2021
@kjozwiak kjozwiak deleted the pr10181_ksmith-rewards-panel-notes_1.31.x branch September 29, 2021 04:03
@kjozwiak kjozwiak mentioned this pull request Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@jumde jumde Awaiting requested review from jumde

@emerick emerick Awaiting requested review from emerick

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.31.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases