Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uplift 1.35.x) Update keys if opened by direct link (#11789) #11863

Merged
merged 1 commit into from
Jan 17, 2022
Merged

(uplift 1.35.x) Update keys if opened by direct link (#11789) #11863

merged 1 commit into from
Jan 17, 2022

Conversation

spylogsster
Copy link
Contributor

Uplift of #11789
Resolves brave/brave-browser#20341

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster
Update keys if opened by direct link
4a8ebef 
(cherry picked from commit 00dd77f)
@spylogsster spylogsster requested a review from a team January 15, 2022 09:40
@kjozwiak kjozwiak added this to the 1.35.x - Beta milestone Jan 17, 2022
kjozwiak
kjozwiak approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.35.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#20341 (comment).

@kjozwiak kjozwiak merged commit c3c8aff into 1.35.x Jan 17, 2022
@kjozwiak kjozwiak deleted the pr11789_uplift_1.35.x branch January 17, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@spylogsster @kjozwiak