brave://settings/ipfs/keys is blank

[stephendonner]

Description

brave://settings/ipfs/keys is blank

Steps to Reproduce

1. new profile
2. launch Brave
3. load ipns://en.wikipedia-on-ipfs.org
4. click on Use a local node at the interstitial screen
5. open brave://settings/ipfs/keys

Actual result:

brave://settings/ipfs/keys is blank

Expected result:

There should be a pre-existing self key (IIRC) and an Add button.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.33.106 Chromium: 96.0.4664.110 (Official Build) (arm64)
Revision	d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS	macOS Version 11.6 (Build 20G165)

I can reproduce this using both go-ipfs versions 0.10.0 and 0.11.0.

cc @spylogsster @lidel

[stephendonner]

BTW, it's not always blank. Still not 100% sure when it gets enabled, but working on reproducing it further.

Got it working in 1.34.80 just now:

[stephendonner]

Verified PASSED using

Brave	1.36.37 Chromium: 97.0.4692.71 (Official Build) nightly (x86_64)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	macOS Version 11.6.1 (Build 20G224)

Followed the original steps to reproduce, and confirm that brave://settings/ipfs/keys loads correctly.

[kjozwiak]

@spylogsster @spylogsster should we get this uplifted into 1.34.x? Sounds like it was broken sometime in 1.33.x. Maybe 1.35.x as it doesn't seem like we're getting any user reports so maybe not urgent enough to get into 1.34.x. Thoughts?

[kjozwiak]

Removing QA Pass-macOS so this can get re-checked in 1.34.x once we get an RC. Uplifted into 1.34.x via brave/brave-core#11862. Used the verification that @stephendonner did via #20341 (comment) on master as the required check before uplifting.

[stephendonner]

Verified PASSED using

Brave	1.34.81 Chromium: 97.0.4692.99 (Official Build) (x86_64)
Revision	d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS	macOS Version 11.6.1 (Build 20G224)

Steps:

1. new profile
2. launched Brave
3. loaded ipns://en.wikipedia-on-ipfs.org
4. clicked on Use a local node at the interstitial screen
5. opened brave://settings/ipfs/keys

Confirmed I saw my pre-populatedself key and the Add button.

---

Verified PASSED using

Brave	1.34.81 Chromium: 97.0.4692.99 (Official Build) (64-bit)
Revision	d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS	Windows 10 Version 20H2 (Build 19042.1466)

Same steps and results as above 👍

---

Verification passed on

Brave	1.34.81 Chromium: 97.0.4692.99 (Official Build) (64-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Ubuntu 18.04 LTS