Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adblock-rust to v0.5.1 #12782

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Update adblock-rust to v0.5.1 #12782

merged 1 commit into from
Mar 28, 2022

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#21932

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Visit https://www.uploadbank.com/yt9ri1rtc0fg and confirm that no anti-Brave interstitial page is shown.

@antonok-edm antonok-edm requested a review from a team as a code owner March 28, 2022 18:18
@antonok-edm antonok-edm self-assigned this Mar 28, 2022
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Mar 28, 2022
@antonok-edm antonok-edm requested review from pes10k and ryanbr March 28, 2022 18:19
@antonok-edm antonok-edm added this to the 1.39.x - Nightly milestone Mar 28, 2022
@antonok-edm antonok-edm merged commit 99f8959 into master Mar 28, 2022
@antonok-edm antonok-edm deleted the adblock-rust-v0.5.1 branch March 28, 2022 18:27
brave-builds pushed a commit that referenced this pull request Mar 28, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.39.13 Chromium: 100.0.4896.56 (Official Build) nightly (64-bit)
-- | --
Revision | 146d253c374b0308e6379ff37f0a0f8c6dffa759-refs/branch-heads/4896@{#827}
OS | Windows 11 Version 21H2 (Build 22000.556)

Verified the STR/Cases outlined via #12782 (comment).

Example (Broken) Example (Fixed)
affectedExample FixedExample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continue executing all cosmetic scriptlets even if one fails
3 participants