Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): implement account selector #13359

Merged
merged 2 commits into from
May 19, 2022
Merged

feat(wallet): implement account selector #13359

merged 2 commits into from
May 19, 2022

Conversation

Pavneet-Sing
Copy link

@Pavneet-Sing Pavneet-Sing commented May 17, 2022 •
edited
Loading

  • Implement add account menu
  • Fix wallet panel header UI
  • Implement domain data sharing

Resolves brave/brave-browser#22126

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

change.account.mp4

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 17, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this May 17, 2022
@Pavneet-Sing Pavneet-Sing force-pushed the open-account-in-dapp-panel branch from 911adfd to b1f7471 Compare May 17, 2022 16:24
@SergeyZhukovsky
Copy link
Member

Please use a short address form in Accounts list, the same strip method we use for all visible addresses Utils.stripAccountAddress

Pavneet-Sing added 2 commits May 19, 2022 17:51
feat(wallet): implement account selector
e6ebab6 
    - implement add account menu
    - fix wallet panel header UI
    - implement domain data sharing
hide address and use setnetwork call when required
6e727df
@Pavneet-Sing Pavneet-Sing force-pushed the open-account-in-dapp-panel branch from b1f7471 to 6e727df Compare May 19, 2022 17:43
SergeyZhukovsky
SergeyZhukovsky approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Pavneet-Sing Pavneet-Sing added this to the 1.41.x - Nightly milestone May 19, 2022
@Pavneet-Sing Pavneet-Sing merged commit 151ab22 into master May 19, 2022
@Pavneet-Sing Pavneet-Sing deleted the open-account-in-dapp-panel branch May 19, 2022 18:48
brave-builds pushed a commit that referenced this pull request May 19, 2022
@brave-browser-releases
Uplift of #13359 (squashed) to beta
20a8d2a
@brave-builds brave-builds mentioned this pull request May 19, 2022
Merged
7 tasks
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.41.15 Custom Build

  • Verified steps from PR
  • Verified able to switch between accounts in the panel via account selector
  • Encountered #23079
13359.mp4

@srirambv srirambv mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@qamarngr qamarngr Awaiting requested review from qamarngr

Assignees

@Pavneet-Sing Pavneet-Sing

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.41.x - Release
Development

Successfully merging this pull request may close these issues.

Dapps panel: Open accounts selection in a DApps panel
3 participants
@Pavneet-Sing @SergeyZhukovsky @srirambv