Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DApps: Improve account switch transition in panel #23079

Closed
srirambv opened this issue May 26, 2022 · 4 comments · Fixed by brave/brave-core#16355
Closed

DApps: Improve account switch transition in panel #23079

srirambv opened this issue May 26, 2022 · 4 comments · Fixed by brave/brave-core#16355
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.48.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Improve account switch transition in panel

Steps to reproduce

  1. Create wallet and have multiple accounts created
  2. Trigger wallet icon in URL bar
  3. Select Accounts, has a weird transition where both accounts are selected before the panel closes

Actual result

Change.account.in.panel.mp4

Expected result

Have a more smoother/fluid transition when selecting accounts

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version?NA

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

Custom Build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @qamarngr @SergeyZhukovsky
@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels May 26, 2022
@srirambv srirambv added this to Web3 May 26, 2022
@srirambv srirambv mentioned this issue May 26, 2022
Merged
25 tasks
@Pavneet-Sing
Copy link

Pavneet-Sing commented May 26, 2022 •
edited
Loading

@srirambv DApps UI is yet to be polished so I think we can keep a single list of issues to keep track of minor UI changes?

@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jun 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@SergeyZhukovsky SergeyZhukovsky changed the title Improve account switch transition in panel DApps: Improve account switch transition in panel Jun 8, 2022
@deeppandya deeppandya added the polish Nice to have — usually related to front-end/visual tasks label Jun 15, 2022
@Pavneet-Sing
Copy link

Pavneet-Sing commented Jun 15, 2022 •
edited
Loading

Note: Reassigning to @qamarngr as he has the bandwidth to work on it. The whole list can be updated at once with notifyDataSetChanged but the catch is to avoid the flicker. Discuss with @jamesmudgett to confirm.

@qamarngr qamarngr moved this from Backlog to In Progress in Web3 Jun 16, 2022
@qamarngr qamarngr mentioned this issue Jun 20, 2022
Merged
25 tasks
@qamarngr qamarngr mentioned this issue Jun 27, 2022
Merged
25 tasks
@qamarngr qamarngr added this to the 1.42.x - Nightly milestone Jun 27, 2022
@qamarngr qamarngr moved this from In Progress to Backlog in Web3 Jun 28, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 25, 2022
Closed
@srirambv srirambv removed this from the 1.42.x - Release milestone Jul 28, 2022
@srirambv
Copy link
Contributor Author

Removing milestone as this is not yet fixed on master

@Pavneet-Sing Pavneet-Sing self-assigned this Dec 13, 2022
This was referenced Dec 13, 2022
Closed
Merged
Repository owner moved this from Backlog to Done in Web3 Dec 14, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 14, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 5, 2023
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Feb 6, 2023

Verification passed on the following devices running 1.48.155 x64 build

  • Verified account change transition is smooth on both wallet panel and on wallet screen
  • Verified test networks are nested inside of the main network name for both Solana and Ethereum
  • Verified changing network via panel and via wallet home page works as expected
  • Verified changing account from picker updates the network as expected
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
23079-ARM.mp4
23079-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.48.x - Release
6 participants
@jamesmudgett @deeppandya @qamarngr @Pavneet-Sing @srirambv @brave-builds