Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to Extensions page strings. #1358

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

mkarolin
Copy link
Collaborator

  • Removes IDS_MD_EXTENSIONS_BRAVE_NO_INSTALLED_ITEMS and IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues.
  • Updates extensions web UI page to use the default Chromium string
    instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS.
  • Reverts patch that made those strings accessible to the web UI.
  • Includes updated .grd[p] files resulting from running
    chromium_rebase_l10n as a part of fix for Change "Brave Web Store" strings to "Web Store" brave-browser#2983.

Fixes brave/brave-browser#2982
Fixes brave/brave-browser#2983

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Start Brave with a fresh profile,
Navigate to brave://extensions,
Verify that the page shows text Find extensions and themes in the [Web Store],
Verify that clicking on the link takes you to the Chrome Web Store,
Add one or more extensions,
Return to brave://extensions page,
Verify that the page shows text Find extensions and themes in the [Web Store],
Verify that clicking on the text takes you to the Chrome Web Store,
Return to brave://extensions page,
Click on Details button for any extension installed from Chrome Web Store,
On the details page, verify that the Source shows text Web Extensions Store.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues.
- Updates extensions web UI page to use the default Chromium string
instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS.
- Reverts patch that made those strings accessible to the web UI.
- Includes updated .grd[p] files resulting from running
chromium_rebase_l10n as a part of fix for brave/brave-browser#2983.

Fixes brave/brave-browser#2982
Fixes brave/brave-browser#2983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Brave Web Store" strings to "Web Store" Revert changes to Extensions page strings
2 participants