Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize HTML/JS changes to extensions item_list.html/js. #1615

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 7, 2019

  • Minimizes patch of extensions' page item_list.html/js by externalizing our changes into a separate dom-module,
  • Adds brave_extensions_resources.pak.

Fixes brave/brave-browser#3012

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Copied from #1358:

  • Start Brave with a fresh profile
  • Navigate to brave://extensions
  • Verify that the page shows text Find extensions and themes in the [Web Store]
  • Verify that clicking on the link takes you to the Chrome Web Store
  • Add one or more extensions
  • Return to brave://extensions page
  • Verify that the page shows text Find extensions and themes in the [Web Store],
  • Verify that clicking on the text takes you to the Chrome Web Store
  • Return to brave://extensions page
  • Click on Details button for any extension installed from Chrome Web Store
  • On the details page, verify that the Source shows text Web Extensions Store

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mkarolin mkarolin self-assigned this Feb 7, 2019
@mkarolin mkarolin force-pushed the maxk-brave-browser-3012 branch 2 times, most recently from faab14d to 91d9821 Compare February 9, 2019 00:28
@mkarolin mkarolin added this to the 0.62.x - Nightly milestone Feb 9, 2019
@mkarolin mkarolin changed the title WIP: Externalize HTML/JS changes to extensions item_list.html/js. Externalize HTML/JS changes to extensions item_list.html/js. Feb 9, 2019
@mkarolin mkarolin requested review from petemill and bridiver February 9, 2019 01:15
@mkarolin mkarolin force-pushed the maxk-brave-browser-3012 branch from 91d9821 to a59dfdb Compare February 9, 2019 01:37
@mkarolin mkarolin requested a review from bsclifton February 13, 2019 17:16
@mkarolin mkarolin force-pushed the maxk-brave-browser-3012 branch from a59dfdb to 7a3a54f Compare February 26, 2019 15:49
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 👍 All tests/linting passed, built without issues. Ran through manual test steps (pulled them into this PR)- everything worked great 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly patch Web Store link in brave://extensions
2 participants