Fixes favicon image for verified youtube publishers #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
requested review from
ryanml
and removed request for
ryanml and
jasonrsadler
NejcZdovc
force-pushed
the
verified-image
branch
2 times, most recently
from
dbe9211 to
320b548
Compare
NejcZdovc
commented
Feb 13, 2019
| publisher_info_statement.Run(); | ||
|
|
||
| std::string favicon = info.favicon_url; | ||
| if (!favicon.empty()) { |
There was a problem hiding this comment.
because we have race condition (multiple requests try to update publisher info) we could be overriding already fetched favicon with an empty string (string is empty, because fetch was canceled and default value in struct for favicon is empty string). So we need to be carful when to update favicon.
NejcZdovc
commented
Feb 13, 2019
| sql::Statement publisher_info_statement( | ||
| GetDB().GetCachedStatement(SQL_FROM_HERE, | ||
| "INSERT OR REPLACE INTO publisher_info " | ||
| "(publisher_id, verified, excluded, " | ||
| "name, url, provider, favIcon) " | ||
| "VALUES (?, ?, ?, ?, ?, ?, ?)")); | ||
| "VALUES (?, ?, ?, ?, ?, ?, " | ||
| "(SELECT IFNULL( " |
There was a problem hiding this comment.
if publisher doesn't exist we need to default favicon to empty string
NejcZdovc
force-pushed
the
verified-image
branch
from
320b548 to
37fd855
Compare
NejcZdovc
commented
Feb 13, 2019
| @@ -220,7 +220,7 @@ void BatPublishers::saveVisitInternal( | |||
| publisher_info->favicon_url = fav_icon; | |||
| } | |||
| } else { | |||
| publisher_info->favicon_url = std::string(); | |||
| publisher_info->favicon_url = ledger::clear_favicon; | |||
There was a problem hiding this comment.
we need to force clear if user is not verified
ryanml
reviewed
Feb 14, 2019
NejcZdovc
force-pushed
the
verified-image
branch
from
37fd855 to
986aa50
Compare
ryanml
approved these changes
Feb 14, 2019
NejcZdovc
added a commit
that referenced
this pull request
Feb 14, 2019
Fixes favicon image for verified youtube publishers
NejcZdovc
added a commit
that referenced
this pull request
Feb 14, 2019
Fixes favicon image for verified youtube publishers
This was referenced Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#3324
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: