Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refill unblinded tokens after captcha solving. (uplift to 1.53.x) #19028

Closed
wants to merge 1 commit into from

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Jun 23, 2023

Uplift of #19027
Resolves brave/brave-browser#31182

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@aseren aseren requested a review from tmancey June 23, 2023 21:14
@aseren aseren requested a review from a team as a code owner June 23, 2023 21:14
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@aseren aseren changed the title Fix refill unblinded tokens after captcha solving. Fix refill unblinded tokens after captcha solving. . (uplift to 1.53.x) Jun 24, 2023
@aseren aseren changed the title Fix refill unblinded tokens after captcha solving. . (uplift to 1.53.x) Fix refill unblinded tokens after captcha solving. (uplift to 1.53.x) Jun 24, 2023
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack between @btlechowski & @tmancey, we'll let this one ride the trains in 1.55.x via #19027. If we get enough user reports that's due to the above, we'll uplift it as needed.

@kjozwiak kjozwiak closed this Jun 26, 2023
@kjozwiak kjozwiak deleted the issues/31182_1.53.x branch June 26, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants