Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refill unblinded tokens after captcha solving. (uplift to 1.53.x) #19028

Closed
wants to merge 1 commit into from
Closed

Fix refill unblinded tokens after captcha solving. (uplift to 1.53.x) #19028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions ...ds/core/internal/account/confirmations/refill_unblinded_tokens/refill_unblinded_tokens.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,22 +74,12 @@ void RefillUnblindedTokens::MaybeRefill(const WalletInfo& wallet) {

if (!wallet.IsValid()) {
BLOG(0, "Failed to refill unblinded tokens due to an invalid wallet");

if (delegate_) {
delegate_->OnFailedToRefillUnblindedTokens();
}

return;
return FailedToRefillUnblindedTokens(/*should_retry*/ false);
}

if (!HasIssuers()) {
BLOG(0, "Failed to refill unblinded tokens due to missing issuers");

if (delegate_) {
delegate_->OnFailedToRefillUnblindedTokens();
}

return;
return FailedToRefillUnblindedTokens(/*should_retry*/ false);
}

if (!ShouldRefillUnblindedTokens()) {
Expand Down Expand Up @@ -236,7 +226,7 @@ void RefillUnblindedTokens::GetSignedTokensCallback(
delegate_->OnCaptchaRequiredToRefillUnblindedTokens(*captcha_id);
}

return;
return FailedToRefillUnblindedTokens(/*should_retry*/ false);
}

// Get public key
Expand Down
3 changes: 1 addition & 2 deletions ...nternal/account/confirmations/refill_unblinded_tokens/refill_unblinded_tokens_unittest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,7 @@ TEST_F(BraveAdsRefillUnblindedTokensTest,
.Times(0);

EXPECT_CALL(refill_unblinded_tokens_delegate_mock_,
OnFailedToRefillUnblindedTokens())
.Times(0);
OnFailedToRefillUnblindedTokens());

EXPECT_CALL(refill_unblinded_tokens_delegate_mock_,
OnWillRetryRefillingUnblindedTokens(_))
Expand Down