Allow IPFS Companion Beta to have chrome.sockets.* #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ID of the Stable channel was whitelisted in brave@10f16e6 but we want to allow the ID of Beta channel to have access to those APIs as well. The purpose of opt-in Beta channel is to dogfood and iterate faster without impacting regular user base.
bbondy
approved these changes
Mar 18, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR against
ipfsbranch (cc @bbondy)We want Beta channel to have access to chrome.sockets APIs. I've added
bundle:brave:betatarget to ipfs-companion (ipfs/ipfs-companion@db006df) to ensure thekeyfor Beta channel remains static.The purpose of opt-in Beta channel is to dogfood and iterate faster without impacting regular user base.
The ID of the ipfs-companion from Stable channel was whitelisted in 10f16e6