Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sta-rs and transitive deps, add P3A revision header #21115

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#34530

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries requested review from a team and bridiver as code owners November 25, 2023 02:40
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Nov 25, 2023
@DJAndries
Copy link
Collaborator Author

This PR will be broken until brave/sta-rs#340 and brave/constellation#115 are resolved

@DJAndries DJAndries force-pushed the update-star branch 2 times, most recently from da2a22c to 16d5815 Compare November 27, 2023 07:07
Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bcaller bcaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds two static headers in components/p3a/uploader.cc. The lib.rs changes look like just code formatting / whitespace. Remainder of PR is version bumps and tests.

@DJAndries DJAndries requested a review from a team as a code owner November 29, 2023 02:18
@DJAndries DJAndries changed the title Update sta-rs, add Constellation revision header to separate broken measurements Update sta-rs and transitive deps, add Constellation revision header to separate broken measurements Nov 29, 2023
@DJAndries DJAndries changed the title Update sta-rs and transitive deps, add Constellation revision header to separate broken measurements Update sta-rs and transitive deps, add Constellation revision header Nov 29, 2023
@DJAndries DJAndries changed the title Update sta-rs and transitive deps, add Constellation revision header Update sta-rs and transitive deps, add P3A revision header Nov 29, 2023
@DJAndries DJAndries added the CI/run-windows-x86 Run CI builds for Windows x86 label Nov 29, 2023
@DJAndries DJAndries force-pushed the update-star branch 2 times, most recently from 0c9974d to d9b3cba Compare December 1, 2023 00:47
@DJAndries DJAndries merged commit 0d893a1 into master Dec 5, 2023
18 checks passed
@DJAndries DJAndries deleted the update-star branch December 5, 2023 21:43
@github-actions github-actions bot added this to the 1.63.x - Nightly milestone Dec 5, 2023
brave-builds added a commit that referenced this pull request Dec 5, 2023
kjozwiak pushed a commit that referenced this pull request Dec 8, 2023
@rillian rillian mentioned this pull request Jan 30, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-windows-x86 Run CI builds for Windows x86
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update STAR, add Brave-Constellation-Rev header to uploaded measurements
6 participants