Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete strobe_rng code #21816

Closed
wants to merge 1 commit into from
Closed

Remove obsolete strobe_rng code #21816

wants to merge 1 commit into from

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Jan 30, 2024 •
edited
Loading

This has been obsolete since we switched to the crates.io versions of the sta-rs, adss, and ppoprf crates used by the star/constellation threshold aggregation scheme in #21115.

Pushing this here for demonstration; may be simpler to incorporate in #21759 directly.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@rillian
Remove obsolete strobe_rng code
0ce98e5 
This has been obsolete since we switched to the crates.io versions
of the sta-rs, adss, and ppoprf crates used by the star/constellation
threshold aggregation scheme.
@rillian rillian self-assigned this Jan 30, 2024
@rillian rillian requested review from a team and bridiver as code owners January 30, 2024 16:38
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 30, 2024
@rillian
Copy link
Contributor Author

rillian commented Jan 30, 2024

Closing in favor of #21759.

@rillian rillian closed this Jan 30, 2024
@rillian rillian deleted the strobe-rng branch January 30, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@rillian rillian

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rillian