Browser no longer crashes when upgrading from a v3 to a v5+ database

[jasonrsadler]

Fixes brave/brave-browser#3907

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Windows
  • macOS
  • Linux
• Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
  • Windows
  • macOS
  • Linux
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

1. Start Brave with clean profile and enable rewards.
2. Close Browser.
3. Copy a v3 publisher_info_db (use attached from issue or attached v2 below) to profile/default
4. Start Brave
5. Open Panel or brave://rewards and ensure browser does not crash

Alternatively:

1. Start Brave with clean profile and enable rewards.
2. Download and remove the 'zip' extension from the db file included at the bottom of this comment
3. Replace publisher_info_db with the one downloaded below.
4. Restart Brave and go to brave://rewards or open the panel and ensure database migration completes without crashing browser.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

publisher_info_db.remove_zip_ext.zip

[NejcZdovc]

Nice find. I think that we need to think more future proof, so we need to move all create/index functions inside upgrade process functions. This way for example if we delete activity_info functions older versions still have upgrade path.

[NejcZdovc]

let's add create scripts into migration functions, this way we are future proof

Create scripts have been moved into migration functions. Also some unrelated lint fixes.