-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ads] Add Sponsored Images & Videos option to New Tab Page setting #25108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Storybook has been deployed to preview UI for the latest push |
ios/brave-ios/Sources/Brave/Frontend/Browser/HomePanel/NTPDataSource.swift
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/Brave/Frontend/Browser/HomePanel/NTPDataSource.swift
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/Brave/Frontend/Rewards/BraveRewards.swift
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/Brave/Frontend/Settings/Display/NTPTableViewController.swift
Outdated
Show resolved
Hide resolved
ios/brave-ios/Sources/Brave/Frontend/Settings/Display/NTPTableViewController.swift
Show resolved
Hide resolved
kylehickinson
approved these changes
Aug 14, 2024
aseren
added a commit
that referenced
this pull request
Aug 26, 2024
[ads] Add Sponsored Images & Videos option to New Tab Page setting
7 tasks
kjozwiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
…t to 1.70.x) (#25326) * Merge pull request #25108 from brave/issues/38198 [ads] Add Sponsored Images & Videos option to New Tab Page setting * Merge pull request #25175 from brave/issues/40507 [ads] Add NTP media type p3a metric * Merge pull request #25285 from brave/issues/40605 [ads] Fix NTT video background may be blank after changing NTP media type setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sponsored Images & Videos
option is currently shown forJapan
region only:Sponsored Images & Videos
option is hidden for all other regions:Resolves brave/brave-browser#38198
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Prerequisites to install video NTT staging components
New Tab Takeover video ads are available in staging component updater for iOS.
Steps to setup staging component updater on iOS:
Use Staging CRX components
inSettings -> BraveCore Switches
Test case 1 (Preferences migration check)
Background Images
->Image Type
is set toSponsored
Background
->Media Type
is set toSponsored Images
Background
->Media Type
toDefault Images
Test case 2 (Preferences migration check)
Background Images
->Image Type
toDefault Images
Background
->Media Type
is set toDefault Images
Background
->Media Type
toSponsored Images
Test case 3 (Preferences migration check)
Background Images
->Image Type
is set toSponsored
Background
->Media Type
is set toSponsored Images & Videos
Test case 4 (Fresh install)
Background
->Media Type
is set toSponsored Images
Background
->Media Type
toDefault Images
Test case 5 (Fresh install)
Background
->Media Type
is set toSponsored Images & Videos
Background
->Media Type
toSponsored Images