Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Add Sponsored Images & Videos option to New Tab Page setting #25108

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Aug 13, 2024

Sponsored Images & Videos option is currently shown for Japan region only:

image image

Sponsored Images & Videos option is hidden for all other regions:

image image

Resolves brave/brave-browser#38198

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Prerequisites to install video NTT staging components

New Tab Takeover video ads are available in staging component updater for iOS.
Steps to setup staging component updater on iOS:

  • Fresh install
  • Launch browser
  • Toggle Use Staging CRX components in Settings -> BraveCore Switches
  • Close the browser
  • Join Japan VPN
  • Launch Brave browser
  • Join Brave Rewards
  • Staging components are downloaded and applied in a minute after start

Test case 1 (Preferences migration check)

  • Set your device region to something other than Japan
  • Install the previous version of Brave (version 1.70)
  • Make sure that setting Background Images -> Image Type is set to Sponsored
  • Install the latest version of Brave (version 1.71 and higher)
  • Make sure that setting Background -> Media Type is set to Sponsored Images
  • Make sure Sponsored Images are shown on NTP
  • Set setting Background -> Media Type to Default Images
  • Make sure that Sponsored Images aren't shown on NTP

Test case 2 (Preferences migration check)

  • Set your device region to something other than Japan
  • Install the previous version of Brave (version 1.70)
  • Set setting Background Images -> Image Type to Default Images
  • Install the latest version of Brave (version 1.71 and higher)
  • Make sure that setting Background -> Media Type is set to Default Images
  • Make sure that Sponsored Images aren't shown on NTP
  • Set setting Background -> Media Type to Sponsored Images
  • Make sure Sponsored Images are shown on NTP

Test case 3 (Preferences migration check)

  • Set device region to Japan
  • Install the previous version of Brave (version 1.70)
  • Make sure that setting Background Images -> Image Type is set to Sponsored
  • Install the latest version of Brave (version 1.71 and higher)
  • Make sure that setting Background -> Media Type is set to Sponsored Images & Videos
  • Make sure that Sponsored Images (or Sponsored Videos) are shown on NTP

Test case 4 (Fresh install)

  • Set your device region to something other than Japan
  • Install the latest version of Brave (version 1.71 and higher)
  • Make sure that setting Background -> Media Type is set to Sponsored Images
  • Make sure Sponsored Images are shown on NTP
  • Set setting Background -> Media Type to Default Images
  • Make sure that Sponsored Images aren't shown on NTP

Test case 5 (Fresh install)

  • Set device region to Japan
  • Install the latest version of Brave (version 1.71 and higher)
  • Do prerequisites to install video NTT staging components
  • Make sure that setting Background -> Media Type is set to Sponsored Images & Videos
  • Make sure that Sponsored Videos are shown on NTP
  • Make sure that Sponsored Images are shown on NTP
  • Set setting Background -> Media Type to Sponsored Images
  • Make sure that Sponsored Videos are not shown on NTP
  • Make sure that Sponsored Images are shown on NTP

@aseren aseren requested a review from a team as a code owner August 13, 2024 19:05
@aseren aseren requested a review from tmancey August 13, 2024 19:05
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@aseren aseren requested a review from kylehickinson August 14, 2024 02:44
@aseren aseren merged commit fa1e937 into master Aug 14, 2024
23 checks passed
@aseren aseren deleted the issues/38198 branch August 14, 2024 18:18
@github-actions github-actions bot added this to the 1.71.x - Nightly milestone Aug 14, 2024
aseren added a commit that referenced this pull request Aug 26, 2024
[ads] Add Sponsored Images & Videos option to New Tab Page setting
kjozwiak pushed a commit that referenced this pull request Sep 6, 2024
…t to 1.70.x) (#25326)

* Merge pull request #25108 from brave/issues/38198

[ads] Add Sponsored Images & Videos option to New Tab Page setting

* Merge pull request #25175 from brave/issues/40507

[ads] Add NTP media type p3a metric

* Merge pull request #25285 from brave/issues/40605

[ads] Fix NTT video background may be blank after changing NTP media type setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Add Sponsored Images & Videos option to New Tab Page setting
3 participants