[ads] Fix NTT video background may be blank after changing NTP media type setting #25285
+35
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseren
commented
Aug 22, 2024
| setupBackgroundImage() | ||
|
|
||
| let isTabVisible = viewIfLoaded?.window != nil | ||
| setupBackgroundVideoIfNeeded(shouldCreatePlayer: isTabVisible) |
There was a problem hiding this comment.
Here is a proper place to call setupBackgroundVideoIfNeeded after background is changed (which happens when user changes New Tab Page setting)
There was a problem hiding this comment.
We also need to create AVPlayer object only if current tab is visible to avoid memory/processor consumption.
AVPlayer object will be created during willMove(...) when user switches to tab.
aseren
commented
Aug 22, 2024
| else { | ||
| guard let backgroundVideoPath = background.backgroundVideoPath else { | ||
| videoPlayer = nil | ||
| backgroundView.resetPlayerLayer() |
There was a problem hiding this comment.
We need to free resources and hide play button when the current NTP is changed from NTT video to image background.
aseren
changed the title
kylehickinson
approved these changes
Aug 23, 2024
|
TeamCity build failures are not connected to the current functionality. |
aseren
added a commit
that referenced
this pull request
Aug 26, 2024
[ads] Fix NTT video background may be blank after changing NTP media type setting
7 tasks
kjozwiak
pushed a commit
that referenced
this pull request
Sep 6, 2024
…t to 1.70.x) (#25326) * Merge pull request #25108 from brave/issues/38198 [ads] Add Sponsored Images & Videos option to New Tab Page setting * Merge pull request #25175 from brave/issues/40507 [ads] Add NTP media type p3a metric * Merge pull request #25285 from brave/issues/40605 [ads] Fix NTT video background may be blank after changing NTP media type setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#40605
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: