Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport an upstream fix for geolocation crash. (1.72.x) #26254

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Oct 28, 2024

Backport of https://chromium-review.googlesource.com/c/chromium/src/+/5840695

Fixes brave/brave-browser#41859

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@iefremov iefremov requested a review from a team as a code owner October 28, 2024 11:44
@LaurenWags
Copy link
Member

LaurenWags commented Oct 28, 2024

Verified with

Brave | 1.73.51 Chromium: 131.0.6778.14 (Official Build) nightly (x86_64)
-- | --
Revision | 1ef7fcf4eb55cd9c9c811f0893f46ccdc3a9b8a2
OS | macOS Version 14.7 (Build 23H124)

Using 1.72.89 Chromium: 130.0.6723.70, reproduced the issue:

  1. Disabled wifi in favor of using a wired connection
  2. Launched 1.72.x, close/relaunch to pull griffin
  3. Visit https://www.w3schools.com/html/html5_geolocation.asp
  4. Click "Try it"
  5. Make selection on permission prompt
  6. See "Aw snap" message
Screenshot 2024-10-28 at 11 50 35 AM

Using 1.73.51 Chromium: 131.0.6778.14 and above STR, confirmed no "Aw snap" message but also, no map shown with my location. Geolocation not working on macOS without wifi is logged as brave/brave-browser#24749. But per discussion via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1730123917670219, since the page is no longer crashing we can uplift the fix.

Screenshot 2024-10-28 at 11 54 58 AM

@LaurenWags LaurenWags added this to the 1.72.x - Beta milestone Oct 29, 2024
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.72.x is approved 👍🏻 QA has verified the PR using 1.73.x/Nightly as per #26254 (comment).

@LaurenWags LaurenWags merged commit 5e774aa into 1.72.x Oct 29, 2024
16 checks passed
@LaurenWags LaurenWags deleted the ie_geobackport branch October 29, 2024 12:52
@brave-builds
Copy link
Collaborator

Released in v1.72.91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants