Backport an upstream fix for geolocation crash. (uplift to 1.71.x) #26255
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of https://chromium-review.googlesource.com/c/chromium/src/+/5840695 Fixes brave/brave-browser#41859 Pre-approval checklist: - [ ] You have tested your change on Nightly. - [ ] This contains text which needs to be translated. - [ ] There are more than 7 days before the release. - [ ] I've notified folks in #l10n on Slack that translations are needed. - [ ] The PR milestones match the branch they are landing to. Pre-merge checklist: - [ ] You have checked CI and the builds, lint, and tests all pass or are not related to your PR. Post-merge checklist: - [ ] The associated issue milestone is set to the smallest version that the changes is landed on.
LaurenWags
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Uplift to 1.71.x is approved 👍🏻 QA has verified the PR using 1.73.x/Nightly as per #26254 (comment).
6 tasks
|
Released in v1.71.121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of https://chromium-review.googlesource.com/c/chromium/src/+/5840695
Fixes brave/brave-browser#41859
Pre-approval checklist:
Pre-merge checklist:
Post-merge checklist: