Reddit publishers now appear correctly in publisher panel when account is set to hide from robots #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Jun 7, 2019
| @@ -194,9 +194,10 @@ std::string MediaReddit::GetUserId(const std::string& response) { | |||
| if (response.empty()) { | |||
| return std::string(); | |||
| } | |||
|
|
|||
| std::string pattern(ExtractData(response, "hideFromRobots\":", | |||
There was a problem hiding this comment.
could you please use std::string pattern = and const
NejcZdovc
reviewed
Jun 7, 2019
| @@ -194,9 +194,10 @@ std::string MediaReddit::GetUserId(const std::string& response) { | |||
| if (response.empty()) { | |||
| return std::string(); | |||
| } | |||
|
|
|||
| std::string pattern(ExtractData(response, "hideFromRobots\":", | |||
| "\"isEmployee\"")); | |||
| std::string id(braveledger_media::ExtractData( | |||
There was a problem hiding this comment.
could you please use std::string id =
jasonrsadler
force-pushed
the
reddit_fixup
branch
3 times, most recently
from
6109edb to
dc4a7af
Compare
NejcZdovc
previously approved these changes
Jun 7, 2019
NejcZdovc
reviewed
Jun 7, 2019
|
|
||
| std::string id(braveledger_media::ExtractData( | ||
| response, "hideFromRobots\":false,\"id\":\"t2_", "\"")); | ||
| const std::string pattern = ExtractData(response, "hideFromRobots\":", |
There was a problem hiding this comment.
nit: we always use braveledger_media:: ExtractData
jasonrsadler
force-pushed
the
reddit_fixup
branch
from
dc4a7af to
fac91f8
Compare
NejcZdovc
approved these changes
Jun 7, 2019
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#4754
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
(use reddit.com/u/jsadler-brave as an example of search indexing turned off)
Reviewer Checklist:
After-merge Checklist:
changes has landed on.