Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add localization strings to cosmetic filter #2692

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Conversation

Snuupy
Copy link
Contributor

@Snuupy Snuupy commented Jun 14, 2019

closes brave/brave-browser#3094

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.
  • Push translations to Transifex

@Snuupy Snuupy changed the title WIP: add localization strings to cosmetic filter add localization strings to cosmetic filter Jun 17, 2019
@Snuupy Snuupy requested review from cezaraugusto and bsclifton June 17, 2019 08:35
@Snuupy Snuupy self-assigned this Jun 17, 2019
@Snuupy Snuupy marked this pull request as ready for review June 17, 2019 08:35
@Snuupy Snuupy added the l10n label Jun 17, 2019
@Snuupy Snuupy force-pushed the contextMenul10n branch 2 times, most recently from cd407e5 to a5f701d Compare June 17, 2019 16:09
@Snuupy Snuupy force-pushed the contextMenul10n branch from a5f701d to 5a2644a Compare June 17, 2019 22:01
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; verified strings are shown as expected. Didn't test other languages, but there aren't translations for those. We'll need to push this to Transifex after merging

Approved, pending CI looking good (can't check it right now, but should be able to in the office tomorrow 😄)

@bsclifton
Copy link
Member

Updated After-merge Checklist to have a step for pushing translations to Transifex 👍

@bsclifton
Copy link
Member

Confirmed CI looks great! 😄 Gonna go ahead and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block element via selector context menu is not translated to other locales
3 participants