Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add localization strings to cosmetic filter #2692

Merged
merged 1 commit into from
Jun 18, 2019
Merged

add localization strings to cosmetic filter #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions components/brave_extension/extension/brave_extension/_locales/en_US/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,5 +146,17 @@
"changeDefaults": {
"message": "Change global shield defaults",
"description": "Message for the button action linking to the settings page"
},
"addBlockElement": {
"message": "Block element via selector",
"description": "Message for context menu that adds a filter for the cosmetic filtering"
},
"resetSiteFilterSettings": {
"message": "Clear CSS rules for this site",
"description": "Message for context menu that resets the site filters for cosmetic filtering"
},
"resetAllFilterSettings": {
"message": "Clear CSS rules for all sites",
"description": "Message for context menu that resets all cosmetic filters"
}
}
7 changes: 4 additions & 3 deletions ...nents/brave_extension/extension/brave_extension/background/events/cosmeticFilterEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import cosmeticFilterActions from '../actions/cosmeticFilterActions'
import { getLocale } from '../api/localeAPI'

export let rule = {
host: '',
Expand All @@ -13,19 +14,19 @@ chrome.contextMenus.create({
})
// block ad child menu
chrome.contextMenus.create({
title: 'Block element via selector',
title: getLocale('addBlockElement'),
id: 'addBlockElement',
parentId: 'brave',
contexts: ['all']
})
chrome.contextMenus.create({
title: 'Clear CSS rules for this site',
title: getLocale('resetSiteFilterSettings'),
id: 'resetSiteFilterSettings',
parentId: 'brave',
contexts: ['all']
})
chrome.contextMenus.create({
title: 'Clear CSS rules for all sites',
title: getLocale('resetAllFilterSettings'),
id: 'resetAllFilterSettings',
parentId: 'brave',
contexts: ['all']
Expand Down