Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a single sequenced task runner for HTTPSEverywehre && level_db init fix #378

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Use a single sequenced task runner for HTTPSEverywehre && level_db init fix #378

merged 3 commits into from
Aug 31, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 31, 2018 •
edited
Loading

Use a single sequenced task runner for HTTPSEverywehre

Otherwise we're creating lots of different threads and accessing things for the DB on different possibly overlapping threads.

Fix brave/brave-browser#896

I think this also fixes:

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Aug 31, 2018
@bbondy bbondy requested a review from simonhong August 31, 2018 03:57
@bbondy bbondy force-pushed the https-everywhere-fixes branch from 99ba177 to 57bc839 Compare August 31, 2018 04:02
@bbondy bbondy requested a review from bridiver August 31, 2018 04:16
simonhong
simonhong previously approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy force-pushed the https-everywhere-fixes branch from 57bc839 to 259af5b Compare August 31, 2018 14:42
@bbondy bbondy merged commit 1a06814 into master Aug 31, 2018
@bsclifton bsclifton deleted the https-everywhere-fixes branch September 26, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonhong simonhong simonhong left review comments

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bbondy @simonhong