Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tightens up spacing in grant captcha panel #3996

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Tightens up spacing in grant captcha panel #3996

merged 1 commit into from
Nov 18, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 14, 2019

Fixes brave/brave-browser#6879

This tightens up the spacing around elements during captcha solve, this provides some leeway for the captcha image without creating a vertical overflow

Submitter Checklist:

Test Plan:

Defined in issue, please test a few times

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.3.x - Nightly milestone Nov 14, 2019
@ryanml ryanml requested a review from a team November 14, 2019 19:13
@ryanml ryanml self-assigned this Nov 14, 2019
@ryanml ryanml merged commit 3d75184 into master Nov 18, 2019
@ryanml ryanml deleted the fix-6879 branch November 18, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Target is sometimes not shown fully on panel captcha
2 participants