-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix chrome password importing is failed on Win #5300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To read chrome's login data, chrome's encryption key is used. To do this, fetching key from local prefs and set it in importing service process.
simonhong
force-pushed
the
fix_password_import_failure_on_windows
branch
from
April 22, 2020 00:16
d2acb13
to
80bfef0
Compare
mkarolin
reviewed
Apr 22, 2020
mkarolin
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
brave-builds
pushed a commit
that referenced
this pull request
Apr 26, 2020
4 tasks
simonhong
added a commit
that referenced
this pull request
Apr 27, 2020
…ndows Fix chrome password importing is failed on Win
4 tasks
Reproduced the original issue on
Verification PASSED* on
Saved the following passwords under
Passwords being imported from Ensuring that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To read chrome's login data, chrome's encryption key is used.
To do this, fetching key from local prefs and set it in importing
service process.
Resolves brave/brave-browser#3674
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Launch browser and import chrome's password with brave://settings/importData.
Select Chrome profile (ensure that the Chrome profile has 2-3 passwords saved) and select
Saved Passwords
Check Chrome's password is properly imported in brave://settings/passwords
Create a new profile.
On second screen of brave://welcome/
Import Bookmarks and Settings.
Choose Chrome profile in Import and Settings screen
Check Chrome's password is properly imported in brave://settings/passwords
Reviewer Checklist:
After-merge Checklist:
changes has landed on.