Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chrome password importing is failed on Win #5300

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 21, 2020

To read chrome's login data, chrome's encryption key is used.
To do this, fetching key from local prefs and set it in importing
service process.

Resolves brave/brave-browser#3674

Submitter Checklist:

Test Plan:

  1. Launch browser and import chrome's password with brave://settings/importData.

  2. Select Chrome profile (ensure that the Chrome profile has 2-3 passwords saved) and select Saved Passwords

  3. Check Chrome's password is properly imported in brave://settings/passwords

  4. Create a new profile.

  5. On second screen of brave://welcome/ Import Bookmarks and Settings.

  6. Choose Chrome profile in Import and Settings screen

  7. Check Chrome's password is properly imported in brave://settings/passwords

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.9.x - Nightly milestone Apr 21, 2020
@simonhong simonhong self-assigned this Apr 21, 2020
To read chrome's login data, chrome's encryption key is used.
To do this, fetching key from local prefs and set it in importing
service process.
@simonhong simonhong force-pushed the fix_password_import_failure_on_windows branch from d2acb13 to 80bfef0 Compare April 22, 2020 00:16
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit 4b8cb48 into master Apr 24, 2020
@simonhong simonhong deleted the fix_password_import_failure_on_windows branch April 24, 2020 00:08
brave-builds pushed a commit that referenced this pull request Apr 26, 2020
simonhong added a commit that referenced this pull request Apr 27, 2020
…ndows

Fix chrome password importing is failed on Win
@kjozwiak
Copy link
Member

Reproduced the original issue on Win 10 x64 using the following build:

Brave | 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
--- | ---
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | Windows 10 OS Version 1909 (Build 18363.815)
  • attempted importing Chrome passwords via brave://settings/importData
  • attempted importing Chrome passwords via brave://welcome/

Verification PASSED* on Win 10 x64 using the following build:

Brave | 1.10.11 Chromium: 81.0.4044.122 (Official Build) nightly (64-bit)
-- | --
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | Windows 10 OS Version 1909 (Build 18363.815)

Saved the following passwords under Chrome:

Annotation 2020-04-27 165410

  • ensured that importing passwords from Chrome via brave://settings/importData works
  • ensured that importing passwords from Chrome via brave://welcome/ works
  • ensured that Try Again worked when attempting to import from Chrome while it's opened
  • ensured that cookies are not being imported
  • ensured that History and Bookmarks are being imported

Passwords being imported from Chrome:

Annotation 2020-04-27 171918

Ensuring that Try Again worked once Chrome is closed:

Annotation 2020-04-27 173243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing passwords from Chrome is not working
3 participants