Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password import failure on windows (uplift to 1.8) #5380

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 27, 2020

Uplift of #5300
Fixes brave/brave-browser#3674

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

…ndows

Fix chrome password importing is failed on Win
@simonhong simonhong added this to the 1.8.x - Release milestone Apr 27, 2020
@simonhong simonhong requested a review from a team April 27, 2020 05:34
@simonhong simonhong self-assigned this Apr 27, 2020
@kjozwiak
Copy link
Member

Restarting as this never really started due to https://ci.brave.com/job/brave-browser-build-pr/job/fix_password_import_failure_on_windows_1_8/1/execution/node/22/.

hudson.AbortException: Fail: the returned code 502 is not in the accepted range: [[100‥399]]
	at jenkins.plugins.http_request.HttpRequestExecution.responseCodeIsValid(HttpRequestExecution.java:369)
	at jenkins.plugins.http_request.HttpRequestExecution.processResponse(HttpRequestExecution.java:379)
	at jenkins.plugins.http_request.HttpRequestExecution.authAndRequest(HttpRequestExecution.java:295)
	at jenkins.plugins.http_request.HttpRequestExecution.call(HttpRequestExecution.java:226)
Caused: java.lang.IllegalStateException
	at jenkins.plugins.http_request.HttpRequestExecution.call(HttpRequestExecution.java:229)
	at jenkins.plugins.http_request.HttpRequestStep$Execution.run(HttpRequestStep.java:351)
	at jenkins.plugins.http_request.HttpRequestStep$Execution.run(HttpRequestStep.java:330)
	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47)
	at hudson.security.ACL.impersonate(ACL.java:369)
	at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

@kjozwiak
Copy link
Member

Looks like test-browser failed on macOS as per https://ci.brave.com/job/brave-browser-build-pr/job/fix_password_import_failure_on_windows_1_8/2/execution/node/597/log/.

15:29:06  [  FAILED  ] BraveRewardsBrowserTest.NotVerifiedWallet, where TypeParam =  and GetParam() =  (6508 ms)
15:29:06  [540/540] BraveRewardsBrowserTest.NotVerifiedWallet (6608 ms)
15:29:06  1 test failed:
15:29:06      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2323)

However, this is a known intermittent issue and not specific to this particular PR.

@kjozwiak
Copy link
Member

QA verified #5300 on Nightly via #5300 (comment). @rebron also verified on Nightly via brave/brave-browser#3674.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the current labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 636dacb into 1.8.x Apr 27, 2020
@kjozwiak kjozwiak deleted the fix_password_import_failure_on_windows_1_8 branch April 27, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants