-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle 404 and 403 errors from uphold #5470
Conversation
c5bb277
to
3e87572
Compare
@@ -1522,10 +1522,9 @@ void RewardsDOMHandler::OnFetchBalance( | |||
base::DictionaryValue data; | |||
data.SetIntKey("status", result); | |||
base::Value balance_value(base::Value::Type::DICTIONARY); | |||
balance_value.SetDoubleKey("total", balance->total); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since balance
is always valid, do we need the && balance
check in the if
below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was my mistake as balance can be null, so we should still have checks for it. Fixed
7977759
to
b2a4de0
Compare
b2a4de0
to
f2e9b10
Compare
CI passed on everything except brave/brave-browser#9687 |
Verified using
Prior to changing the After changing the
Note - attempted to reconnect after completing the test plan, but was unsuccessful. Reviewed and discussed with @NejcZdovc - logged brave/brave-browser#9780. |
Resolves brave/brave-browser#9653
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
external_wallets->uphold->address
to something randomReviewer Checklist:
After-merge Checklist:
changes has landed on.