Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect uphold if we get 403 from uphold #9653

Closed
NejcZdovc opened this issue May 6, 2020 · 1 comment · Fixed by brave/brave-core#5470
Closed

Disconnect uphold if we get 403 from uphold #9653

NejcZdovc opened this issue May 6, 2020 · 1 comment · Fixed by brave/brave-core#5470

Comments

@NejcZdovc
Copy link
Contributor

Description

Right now when there is uphold server problem 403 or 404 (when fetching a balance) we return error to the UI that sticks. What we should do is in this cases disconnect wallet and return ok to the UI.

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member

LaurenWags commented May 18, 2020

Verified passed with

Brave 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS macOS Version 10.14.6 (Build 18G3020)

Before changing address in Preferences:
Screen Shot 2020-05-18 at 5 35 44 PM

After changing address in Preferences:

[ RESPONSE - OnFetchBalance ]
> time: 1589837628
> result: Failure
> http code: 404

Screen Shot 2020-05-18 at 5 34 22 PM

  • Confirmed able to reconnect to Uphold after running thru test plan.

Verification passed on

Brave 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

After changing the wallet address to random string:
image
After restart, the wallet address is empty
"external_wallets":{"uphold":{"address":"","one_time_string":"4255D5F56724415D90E41BF6C8ABC7157020829669327A1EAFD2B008DF866B86","status":3,"token":"","transferred":false,"user_name":""}}
After reconnecting:
image
Verified the ability to tip after reconnecting

Verification passed on

Brave | 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Before changing address in Preferences:
image

After changing address in Preferences:

[ RESPONSE - OnFetchBalance ]
> time: 1589912613
> result: Failure
> http code: 404

image

  • Confirmed able to reconnect to Uphold after running thru test plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment