Fix timing issue with ProcessPendingContributions browser test #5498
Conversation
emerick
force-pushed
the
rewards-test-process-pending-contributions-fix
branch
from
54318e6 to
3ac72b2
Compare
components/brave_rewards/browser/rewards_service_browsertest.cc
Outdated
Show resolved
Hide resolved
| rewards_service_browsertest_utils::WaitForElementThenClick( | ||
| OpenRewardsPopup(), | ||
| "[data-test-id='unverified-check-button']"); | ||
| // Refresh publisher list; assume that absence of refresh button |
There was a problem hiding this comment.
how come publisher is already verified if we didn't click refresh yet?
There was a problem hiding this comment.
From my understanding of the code the publisher list also updates on a timer, so sometimes the manual click isn't needed.
There was a problem hiding this comment.
interesting so you thing that timer is causing problems
There was a problem hiding this comment.
Yeah, the timer is kicking off the update and updating the server before there's any chance to click the button (at least on my local Windows machine). Once the rewards popup opens, there's no longer a "Refresh Status" button to click on because it's already updated to a verified publisher.
There was a problem hiding this comment.
this happened because we don't send any end when doing pagination, so pagination will continue for 100 pages and because of that we have this race condition
emerick
force-pushed
the
rewards-test-process-pending-contributions-fix
branch
from
3ac72b2 to
eee5fc3
Compare
|
@NejcZdovc found the real fix here #5502, closing. |
Resolves brave/brave-browser#9687
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Run the following command and verify that the test passes:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.