Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix browser test #5502

Merged
merged 1 commit into from
May 10, 2020
Merged

Fix browser test #5502

merged 1 commit into from
May 10, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 10, 2020 •
edited
Loading

Resolves brave/brave-browser#9687

Submitter Checklist:

Test Plan:

  • no test plan needed

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this May 10, 2020
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows labels May 10, 2020
@NejcZdovc NejcZdovc requested a review from a team May 10, 2020 10:02
@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone May 10, 2020
@emerick emerick mentioned this pull request May 10, 2020
Closed
32 tasks
emerick
emerick approved these changes May 10, 2020
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc
Copy link
Contributor Author

CI passed https://ci.brave.com/job/pr-brave-browser-fix-rewards-test/2/

@NejcZdovc NejcZdovc merged commit f02cdc8 into master May 10, 2020
@NejcZdovc NejcZdovc deleted the fix-rewards-test branch May 10, 2020 11:37
@NejcZdovc NejcZdovc mentioned this pull request May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging this pull request may close these issues.

BraveRewardsBrowserTest.ProcessPendingContributions failing on linux
2 participants
@NejcZdovc @emerick