Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset wallet completely on disconnect #5551

Merged
merged 1 commit into from
May 14, 2020
Merged

Reset wallet completely on disconnect #5551

merged 1 commit into from
May 14, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 14, 2020

Resolves brave/brave-browser#9780

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim grant
  • connect KYC wallet with some BAT in it. close rewards page.
  • close browser
  • go to Preferences and change external_wallets->uphold->address to something random
  • start browser
  • go to rewards page
  • make sure that wallet is disconnected and that you see grant balance
  • close browser
  • check Preferences and see that external_wallets->uphold->address is empty
  • start browser
  • connect to uphold again
  • make sure that it works

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone May 14, 2020
@NejcZdovc NejcZdovc requested a review from a team May 14, 2020 16:45
@NejcZdovc NejcZdovc self-assigned this May 14, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit c37c4cc into master May 14, 2020
@NejcZdovc NejcZdovc deleted the reset-wallet branch May 14, 2020 19:21
brave-builds pushed a commit that referenced this pull request May 14, 2020
@LaurenWags
Copy link
Member

Verified using

Brave | 1.11.3 Chromium: 81.0.4044.138 (Official Build) nightly (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from description

KYC'd uphold wallet successfully connected:
Screen Shot 2020-05-15 at 9 38 57 AM

After changing address in Preferences file, confirmed wallet is disconnected:
Screen Shot 2020-05-15 at 9 40 51 AM

Confirmed address is empty in Preferences after being automatically disconnected:
Screen Shot 2020-05-15 at 9 42 08 AM

Confirmed able to connect to Uphold again successfully:
Screen Shot 2020-05-15 at 9 43 14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

address not cleared when automatic disconnect from Uphold occurs
3 participants