Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes balance drop on Android (uplift to 1.10.x) #5940

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 25, 2020

Uplift of #5935
Resolves brave/brave-browser#9992

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • Compiled this branch from source and manually tested!
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc requested a review from a team June 25, 2020 00:10
@NejcZdovc NejcZdovc self-assigned this Jun 25, 2020
@NejcZdovc NejcZdovc force-pushed the fix-empty-balance-1.10 branch 4 times, most recently from fe464a6 to 18b0a13 Compare June 25, 2020 06:36
@NejcZdovc NejcZdovc force-pushed the fix-empty-balance-1.10 branch from 18b0a13 to a30fa13 Compare June 25, 2020 07:25
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built from scratch locally (1.10.x) and ran through two scenarios with @NejcZdovc over Zoom:

  1. Recover unused grant:
  • new profile
  • claim grant; verify amount shows
  • quit browser
  • edit Default/publisher_info_db:
    • delete all unblinded_tokens entries
    • change type in promotion from 0 to 1
  • edit default/Preferences file; change empty_balance_checked to false
  • full grant immediately recovered 🎉
  1. Recover partially used grant:
  • new profile
  • claim grant; verify amount shows
  • make a 5 BAT tip to https://bvsriram.github.io/ and verify amount is deducted
  • edit Default/publisher_info_db:
    • delete all unblinded_tokens entries
    • change type in promotion from 0 to 1
  • edit default/Preferences file; change empty_balance_checked to false
  • proper grant amount discovered- server is notified of the proper amount and sends back a 201 SUCCESS response 🎉

Ran locally built using npm run start -- --rewards=development=true --log-level=2 --enable-logging=stderr

@bsclifton bsclifton mentioned this pull request Jun 25, 2020
32 tasks
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Jun 25, 2020

CI only failed on macos browser test https://ci.brave.com/job/pr-brave-browser-fix-empty-balance-1.10/6/execution/node/542/log/

1 test failed:
10:14:48      BraveRewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2433)

It's a known intermittent problem. All is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants