Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes balance drop on android #5935

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Fixes balance drop on android #5935

merged 1 commit into from
Jun 29, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jun 24, 2020

Resolves brave/brave-browser#9992
Resolves brave/brave-browser#10471

Submitter Checklist:

Test Plan:

Plan 1:

  1. start browser on master
  2. enable rewards
  3. claim grant
  4. close browser
  5. open DB and change:
    • type in promotion table from 0 to 1
    • empty unblinded_tokens table
  6. start browser and make sure that balance is 0
  7. close browser
  8. switch to this PR
  9. start browser
  10. make sure that balance is showing correct again

Plan 2:

  1. start browser on master
  2. enable rewards
  3. claim grant
  4. make a tip
  5. close browser
  6. open DB and change:
    • type in promotion table from 0 to 1
    • empty unblinded_tokens table
  7. start browser and make sure that balance is 0
  8. close browser
  9. switch to this PR
  10. start browser
  11. make sure that balance is still showing 0
  12. open logs and make sure that you see this request and success response for it
[ REQUEST ]
> URL: https://grant.rewards.brave.software/v1/wallets/{paymentId}/events/batloss/1
> Method: UrlMethod::PUT
> Content: {"amount": 19.000000}
> Content Type: application/json; charset=utf-8

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Jun 24, 2020
@NejcZdovc NejcZdovc marked this pull request as draft June 24, 2020 19:52
@NejcZdovc NejcZdovc force-pushed the fix-empty-balance branch from f66813f to 4bd68a7 Compare June 24, 2020 23:38
@NejcZdovc NejcZdovc requested a review from bsclifton June 24, 2020 23:50
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jun 24, 2020
@NejcZdovc NejcZdovc force-pushed the fix-empty-balance branch from 4bd68a7 to fbab16c Compare June 24, 2020 23:50
@NejcZdovc NejcZdovc marked this pull request as ready for review June 24, 2020 23:52
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed logic over Zoom; looks great! 😄

@bsclifton
Copy link
Member

Verified logic on 1.10 (see #5940 (review))

@NejcZdovc NejcZdovc force-pushed the fix-empty-balance branch from 950b64d to 949ed18 Compare June 29, 2020 05:33
@NejcZdovc NejcZdovc merged commit 3d1e1d5 into master Jun 29, 2020
@NejcZdovc NejcZdovc deleted the fix-empty-balance branch June 29, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants