Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for initial rewards API parameter fetch from server (uplift to 1.12.x) #6048

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Wait for initial rewards API parameter fetch from server (uplift to 1.12.x) #6048

merged 1 commit into from
Jul 14, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 9, 2020 •
edited by kjozwiak
Loading

Uplift of #6002
Resolves brave/brave-browser#10438

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from NejcZdovc as a code owner July 9, 2020 09:53
@brave-builds brave-builds requested a review from a team July 9, 2020 09:53
@brave-builds brave-builds self-assigned this Jul 9, 2020
@brave-builds brave-builds added this to the 1.12.x - Beta milestone Jul 9, 2020
@NejcZdovc NejcZdovc removed their request for review July 9, 2020 11:05
@kjozwiak
Copy link
Member

test-install failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr6002_ksmith-wait-for-api-params_1.12.x/1/execution/node/660/log/ which is a known intermittent issue and doesn't block uplift.

test-browser failed on Win x64 as per https://ci.brave.com/job/pr-brave-browser-pr6002_ksmith-wait-for-api-params_1.12.x/1/execution/node/638/log/.

07:25:23  1 test failed:
07:25:23      SpeedReaderBrowserTest.SmokeTest (../../brave/browser/speedreader/speedreader_browsertest.cc:65)

However, this is a known intermittent issue as well and doesn't block uplift.

kjozwiak
kjozwiak approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on 1.11.x via PR builds as per #6050 (comment).

@kjozwiak kjozwiak merged commit 83d104b into 1.12.x Jul 14, 2020
@kjozwiak kjozwiak deleted the pr6002_ksmith-wait-for-api-params_1.12.x branch July 14, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/rewards
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @NejcZdovc @brave-browser-releases