Search update 1.12.x (uplift to 1.12.x) #6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
changed the title
deeppandya
changed the title
|
Notes:
|
deeppandya
force-pushed
the
search-update-1.12.x
branch
2 times, most recently
from
b2ff9c2 to
45fefd4
Compare
|
We need to have #6273 uplift for 1.12 |
|
@deeppandya can you cherry-pick that into here too? |
yeah so i was thinking the same. but wanted to check first. i will update this PR |
|
Looks like there was a timeout on Windows; all other platforms passed just fine. Restarting for Windows only |
bsclifton
added
CI/skip-android
|
Leaving skipped tags for other platforms; pinged @deeppandya about rebase of Android only file. We can resolve and let CI run for Android, then it's ready for approval 😄 |
Yahoo using SYC (search.yahoo.com) is split by region. Placeholders created for most regions. Fixes brave/brave-browser#10890
- Added vector icon (not used yet) - added PNG files (multiple resolutions) - added enum value / wired up to onboarding screen
Update code to show Yahoo on seach engine page
This fixes crash on debug build
bsclifton
force-pushed
the
search-update-1.12.x
branch
from
7bd7de2 to
00b3f14
Compare
|
Rebased! 😄👍 |
kjozwiak
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6201 (comment) & #6201 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #6201
Fixes brave/brave-browser#10890
Approved, please ensure that before merging:
After you merge: