Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change canvas maximum farbling to match balanced farbling #6324

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Aug 3, 2020

Resolves brave/brave-browser#11067

Submitter Checklist:

Test Plan:

  • change shields settings to `Fingerprinting blocked (strict, may break sites)
  • visit YT and play a random video
  • ensure there's no artifacts appearing on the video
  • hover over the video a few times while it's playing and ensure you don't see any artifacts when hovering

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave requested a review from bridiver as a code owner August 3, 2020 21:39
@pilgrim-brave pilgrim-brave self-assigned this Aug 3, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 5, 2020

Reproduced the issue on macOS 10.15.6 x64 using the following build:

Brave 1.14.15 Chromium: 84.0.4147.105 (Official Build) nightly (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS macOS Version 10.15.6 (Build 19G73)

Screen Shot 2020-08-04 at 9 07 26 PM

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave 1.14.18 Chromium: 84.0.4147.105 (Official Build) nightly (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS macOS Version 10.15.6 (Build 19G73)

@kjozwiak kjozwiak added this to the 1.14.x - Nightly milestone Aug 5, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 5, 2020

Added missing 1.14.x - Nightly milestone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change canvas maximum farbling to match balanced farbling
3 participants